Issue 7189044: net: Don't access SECOID_AlgorithmIDTemplate directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7189044: net: Don't access SECOID_AlgorithmIDTemplate directly. (Closed)

Created:
9 years, 6 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

net: Don't access SECOID_AlgorithmIDTemplate directly. This is required when building nss as a dynamic library. BUG=85776 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89732

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	crypto/signature_verifier_nss.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	net/base/dnssec_keyset.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

wtc

Can you also fix the following? ./crypto/signature_verifier_nss.cc: rv = SEC_QuickDERDecodeItem(arena, &sig_alg_id, SECOID_AlgorithmIDTemplate, ./chrome/browser/importer/nss_decryptor_system_nss.cc: rv = ...

9 years, 6 months ago (2011-06-17 22:15:52 UTC) #4

rvargas (doing something else)

9 years, 6 months ago (2011-06-18 00:49:01 UTC) #5

> ./chrome/browser/importer/nss_decryptor_system_nss.cc:  rv =
> SEC_QuickDERDecodeItem(arena, &sdrResult, g_template, data);

This one is not using the nss template.

Expand Messages | Collapse Messages