Implement an initial extension settings API.

chrome/common/extensions/api/extension_api.json

Index: chrome/common/extensions/api/extension_api.json
diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json
index 1613b9053703ece72a046054c8a6f05fad42fed3..f20060c42f44b863b60079a7ef6bd8e81bf5b4ce 100644
--- a/chrome/common/extensions/api/extension_api.json
+++ b/chrome/common/extensions/api/extension_api.json
@@ -699,6 +699,124 @@
     ]
   },
   {
+    "namespace": "experimental.settings",
+    "types": [],
+    "functions": [
+      {
+        "name": "get",
+        "type": "function",
+        "description": "Gets one or more values from settings.",
+        "parameters": [
+          {
+            "name": "keys",
+            "choices": [
+              {"type": "string"},
+              {"type": "array", "items": {"type": "string"}, "minItems": 1}
+            ],
+            "description": "A single key or a list of keys to get from settings. Leave empty to get the entire contents of settings; this should only be used for debugging.",
+            "optional": true
+          },
+          {
+            "name": "callback",
+            "type": "function",
+            "description": "Callback with settings values, or on failure (in which case lastError will be set).",
+            "parameters": [
+              {
+                "name": "settings",
+                "type": "object",
+                "properties": {},
+                "additionalProperties": { "type": "any" },
+                "description": "Object with given keys set to settings values."
+              }
+            ]
+          }
+        ]
+      },
+      {
+        "name": "set",
+        "type": "function",
+        "description": "Sets multiple settings values.",
+        "parameters": [
+          {
+            "name": "settings",
+            "type": "object",
+            "properties": {},
+            "additionalProperties": { "type": "any" },
+            "description": "Object to augment settings with. Values that cannot be serialized (functions, etc) will be ignored."
+          },
+          {
+            "name": "callback",
+            "type": "function",
+            "description": "Callback with settings values, or on failure (in which case lastError will be set).",
+            "parameters": [
+              {
+                "name": "settings",
+                "type": "object",
+                "properties": {},
+                "additionalProperties": { "type": "any" },
+                "description": "Object with given keys set to settings values."
+              }
+            ],
+            "optional": true
+          }
+        ]
+      },
+      {
+        "name": "remove",
+        "type": "function",
+        "description": "Removes one or more values from settings.",
+        "parameters": [
+          {
+            "name": "keys",
+            "choices": [
+              {"type": "string"},
+              {"type": "array", "items": {"type": "string"}, "minItems": 1}
+            ],
+            "description": "A single key or a list of keys to remove from settings."
+          },
+          {
+            "name": "callback",
+            "type": "function",
+            "description": "Callback with an empty settings object, or on failure (in which case lastError will be set).",

[Matt Perry, 2011/06/29 18:08:11]

I didn't notice this before, but why are we passing an empty object? We can pass
no arguments, and just have lastError set on an error.

[not at google - send to devlin, 2011/08/03 06:36:51]

Initially so that, C++ implementation wise, all methods can use the same
callback types; just a DictionaryValue.

From an API standpoint this arguably doesn't make much sense, but I can see it
being useful even for a developer to have all these functions have the same
type, if function pointers are passed around... or something.

[Matt Perry, 2011/08/03 22:57:47]

If you pass NULL to that callback (which then sets the
ExtensionFunction::result_ to NULL), it will pass no arguments to the callback.

[not at google - send to devlin, 2011/08/04 00:59:06]

Done.

+            "parameters": [
+              {
+                "name": "settings",
+                "type": "object",
+                "properties": {},
+                "additionalProperties": { "type": "any" },
+                "description": "An empty object."
+              }
+            ],
+            "optional": true
+          }
+        ]
+      },
+      {
+        "name": "clear",
+        "type": "function",
+        "description": "Removes all values from settings.",
+        "parameters": [
+          {
+            "name": "callback",
+            "type": "function",
+            "description": "Callback with an empty settings object, or on failure (in which case lastError will be set).",

[Matt Perry, 2011/06/29 18:08:11]

ditto

[not at google - send to devlin, 2011/08/04 00:59:06]

Done.

+            "parameters": [
+              {
+                "name": "settings",
+                "type": "object",
+                "properties": {},
+                "additionalProperties": { "type": "any" },
+                "description": "An empty object."
+              }
+            ],
+            "optional": true
+          }
+        ]
+      }
+    ],
+    "events": []
+  },
+  {
     "namespace": "windows",
     "types": [
       {