Reinitialize the arguments object in d8 when renewing the evaluation context (fixes issue 1477).

src/d8.cc

Index: src/d8.cc
===================================================================
--- src/d8.cc	(revision 8295)
+++ src/d8.cc	(working copy)
@@ -650,6 +650,20 @@
   evaluation_context_ = Context::New(NULL, global_template);
   evaluation_context_->SetSecurityToken(Undefined());
 
+  Context::Scope utility_scope(utility_context_);

[Søren Thygesen Gjesse, 2011/06/16 08:22:20]

Isn't this code now repeated twice (also in Shell::Initialize())? Please
refactor into a function.

[Rico, 2011/06/16 08:35:18]

As discussed offline, the other place where this is used has no effect
whatsoever, so I removed that instead.

+  i::JSArguments js_args = i::FLAG_js_arguments;
+  i::Handle<i::FixedArray> arguments_array =
+      FACTORY->NewFixedArray(js_args.argc());
+  for (int j = 0; j < js_args.argc(); j++) {
+    i::Handle<i::String> arg =
+        FACTORY->NewStringFromUtf8(i::CStrVector(js_args[j]));
+    arguments_array->set(j, *arg);
+  }
+  i::Handle<i::JSArray> arguments_jsarray =
+      FACTORY->NewJSArrayWithElements(arguments_array);
+  evaluation_context_->Global()->Set(String::New("arguments"),
+                                     Utils::ToLocal(arguments_jsarray));
+
 #ifdef ENABLE_DEBUGGER_SUPPORT
   i::Debug* debug = i::Isolate::Current()->debug();
   debug->Load();