Issue 7189007: Reinitialize the arguments object in d8 when renewing the evaluation context (fixes issue 1477).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7189007: Reinitialize the arguments object in d8 when renewing the evaluation context (fixes issue 1477). (Closed)

Created:
9 years, 6 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reinitialize the arguments object in d8 when renewing the evaluation context (fixes issue 1477). Committed: http://code.google.com/p/v8/source/detail?r=8312

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
	M	src/d8.cc	View	1	2 chunks	+14 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/7189007/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7189007/diff/1/src/d8.cc#newcode653 src/d8.cc:653: Context::Scope utility_scope(utility_context_); Isn't this code now repeated twice ...

9 years, 6 months ago (2011-06-16 08:22:20 UTC) #2

Rico

9 years, 6 months ago (2011-06-16 08:35:18 UTC) #3

http://codereview.chromium.org/7189007/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/7189007/diff/1/src/d8.cc#newcode653
src/d8.cc:653: Context::Scope utility_scope(utility_context_);
On 2011/06/16 08:22:20, Søren Gjesse wrote:
> Isn't this code now repeated twice (also in Shell::Initialize())? Please
> refactor into a function.
As discussed offline, the other place where this is used has no effect
whatsoever, so I removed that instead.

Expand Messages | Collapse Messages

Issue 7189007: Reinitialize the arguments object in d8 when renewing the evaluation context (fixes issue 1477). (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages