Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/test/ui/ui_test.cc

Issue 7185023: Support Chromium-branded builds and cleanup reference build usage. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed inherited method calls and updated two tests. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/ui/ui_test.cc
diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc
index 283084871e33085de1266844aea76afa7cb3adbf..ce206f28fb9263e79394a8fd0390affa408e31bf 100644
--- a/chrome/test/ui/ui_test.cc
+++ b/chrome/test/ui/ui_test.cc
@@ -89,6 +89,7 @@ UITestBase::UITestBase()
clear_profile_(true),
include_testing_id_(true),
enable_file_cookies_(true),
+ enable_chrome_branding_(true),
profile_type_(ProxyLauncher::DEFAULT_THEME) {
PathService::Get(chrome::DIR_APP, &browser_directory_);
PathService::Get(chrome::DIR_TEST_DATA, &test_data_directory_);
@@ -104,6 +105,7 @@ UITestBase::UITestBase(MessageLoop::Type msg_loop_type)
clear_profile_(true),
include_testing_id_(true),
enable_file_cookies_(true),
+ enable_chrome_branding_(true),
profile_type_(ProxyLauncher::DEFAULT_THEME) {
PathService::Get(chrome::DIR_APP, &browser_directory_);
PathService::Get(chrome::DIR_TEST_DATA, &test_data_directory_);
@@ -174,8 +176,13 @@ ProxyLauncher* UITestBase::CreateProxyLauncher() {
}
ProxyLauncher::LaunchState UITestBase::DefaultLaunchState() {
- FilePath browser_executable = browser_directory_.Append(
- chrome::kBrowserProcessExecutablePath);
+ FilePath browser_executable;
+ if (enable_chrome_branding_)
+ browser_executable = browser_directory_.Append(
+ chrome::kBrowserProcessExecutablePath);
+ else
+ browser_executable = browser_directory_.Append(
+ chrome::kBrowserProcessExecutablePathChromium);
CommandLine command(browser_executable);
command.AppendArguments(launch_arguments_, false);
ProxyLauncher::LaunchState state =

Powered by Google App Engine
This is Rietveld 408576698