base/file_util_android.h - Issue 7184032: Upstream android file related code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/file_util_android.h

Issue 7184032: Upstream android file related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address the comments Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_FILE_UTIL_ANDROID_H_

	6 #define BASE_FILE_UTIL_ANDROID_H_
	darin (slow to review) 2011/06/20 18:44:01 it really seems wrong to call this file_util* sinc it really seems wrong to call this file_util* since it is not an extension of file_util.h. it is something completely different. it feels more like you might want a name like bsd_compat_android.h since both futimes and mkdtemp are BSD functions that Linux happens to also support. michaelbai 2011/06/20 22:50:36 Rename to os_compat_android.* Show quoted text On 2011/06/20 18:44:01, darin wrote: > it really seems wrong to call this file_util* since it is not an extension of > file_util.h. it is something completely different. > > it feels more like you might want a name like bsd_compat_android.h since both > futimes and mkdtemp are BSD functions that Linux happens to also support. Rename to os_compat_android.*
	7 #pragma once

	8

	9 // Not implemented in Bionic. See platform_file_android.cc.

	10 extern "C" int futimes(int fd, const struct timeval tv[2]);

	11

	12 // The prototype of mkdtemp is missing.

	13 extern "C" char* mkdtemp(char* path);

	14

	15 #endif // BASE_FILE_UTIL_ANDROID_H_

OLD	NEW