base/platform_file_android.h - Issue 7184032: Upstream android file related code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/platform_file_android.h

Issue 7184032: Upstream android file related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update DEPS Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_PLATFORM_FILE_ANDROID_H_

	6 #define BASE_PLATFORM_FILE_ANDROID_H_
	joth 2011/06/19 12:48:05 (Looking for a base OWNER opinion on this; I'm gue (Looking for a base OWNER opinion on this; I'm guessing) I'm not sure about the file name for this cc/h pair. platform_file.h already exists and has a different purpose: it's a cross-platform wrapper that defines PlatformFile typedef and various methods that operate on it. In here we are declaring posix/linux methods that are missing from sys/time.h and stdlib.h Investigating a bit more, based on compat_execinfo.h I think the consistent style would be to split this into a pair of files called base/compat_sys_time.h and base/compat_stdlib.h and use these in place of their name-sakes? brettw 2011/06/20 03:50:40 How about file_util_android.h/cc? I'd rather not h How about file_util_android.h/cc? I'd rather not have two separate headers, each with just one function. file_util is kind of "misc stuff" and I think it's fine if these go in there if you agree.
	7 #pragma once

	8

	9 // Not implemented in Bionic. See platform_file_android.cc.

	10 extern "C" int futimes(int fd, const struct timeval tv[2]);

	11

	12 // The prototype of mkdtemp is missing.

	13 extern "C" char* mkdtemp(char* path);

	14

	15 #endif // BASE_PLATFORM_FILE_ANDROID_H_

OLD	NEW