Issue 7184027: Fix issue 1417: check for script source availability when enumerating optimized functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7184027: Fix issue 1417: check for script source availability when enumerating optimized functions. (Closed)

Created:
9 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), Kasper Lund

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix issue 1417: check for script source availability when enumerating optimized functions. R=kasperl@chromium.org,kmillikin@chromium.org BUG=1417 TEST=test-log/Issue23768 Committed: http://code.google.com/p/v8/source/detail?r=8320

Patch Set 1 #

Total comments: 2

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/log.cc	View		1 chunk	+4 lines, -1 line	2 comments	Download
	M	test/cctest/cctest.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/7184027/diff/1/src/log.cc File src/log.cc (right): http://codereview.chromium.org/7184027/diff/1/src/log.cc#newcode1549 src/log.cc:1549: if (sfi->script()->IsScript() Maybe cache sfi->script() in a new ...

9 years, 6 months ago (2011-06-17 05:20:21 UTC) #2

mnaganov (inactive)

9 years, 6 months ago (2011-06-17 08:37:41 UTC) #3

http://codereview.chromium.org/7184027/diff/1/src/log.cc
File src/log.cc (right):

http://codereview.chromium.org/7184027/diff/1/src/log.cc#newcode1549
src/log.cc:1549: if (sfi->script()->IsScript()
On 2011/06/17 05:20:21, Kasper Lund wrote:
> Maybe cache sfi->script() in a new local? That will make it obvious that
> script() returns a non Script* and help explain why the Script::cast is
required
> without adding more comments.

Done.

Expand Messages | Collapse Messages