MediaStreamDispatcher

content/renderer/media/media_stream_dispatcher.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/media_stream_dispatcher.h"
+
+#include "base/logging.h"
+#include "content/common/media/media_stream_messages.h"
+#include "content/renderer/media/media_stream_dispatcher_eventhandler.h"
+
+// Empty StreamDeviceInfoArray.
+static const media_stream::StreamDeviceInfoArray empty_stream_array =

[scherkus (not reviewing), 2011/06/17 17:42:13]

no good -- we avoid static non-basic data types (i.e., anything from std::
namespace)

[Per K, 2011/06/18 19:53:59]

removed.

+    media_stream::StreamDeviceInfoArray(0);
+
+MediaStreamDispatcherEventHandler::~MediaStreamDispatcherEventHandler() {}
+
+MediaStreamDispatcher::MediaStreamDispatcher(RenderView* render_view)
+    : RenderViewObserver(render_view),
+      next_ipc_id_(0),
+      message_loop_(MessageLoop::current()) {
+}
+
+MediaStreamDispatcher::~MediaStreamDispatcher() {}
+
+void MediaStreamDispatcher::GenerateStream(
+    int request_id,
+    MediaStreamDispatcherEventHandler* event_handler,
+    media_stream::GenerateStreamOptions components,
+    const std::string& security_origin) {
+  DCHECK_EQ(MessageLoop::current(), message_loop_);
+  VLOG(1) << "MediaStreamDispatcher::GenerateStream" << request_id << ")";

[scherkus (not reviewing), 2011/06/17 17:42:13]

nit: you're missing a ( in your log message

[Per K, 2011/06/18 19:53:59]

Done.

+
+  requests_.push_back(Request(event_handler, request_id, next_ipc_id_));

[scherkus (not reviewing), 2011/06/17 17:42:13]

what purpose does next_ipd_id_ serve?

I don't see it being used anywhere other than sitting inside the Request struct

[Per K, 2011/06/18 19:53:59]

  Send(new MediaStreamHostMsg_GenerateStream(routing_id(),
                                             next_ipc_id_++,
                                             components,
                                             security_origin));


It idenfies the requests from clients and maps them to responses in
OnStreamGenerated or OnStreamFailed.

The reason I did not use the request_id as it is in GenerateStream is to handle
the not very likely case of Webkit and another client (pepper ?)  calling
GenerateStream at the same time with the same request_id.

+  Send(new MediaStreamHostMsg_GenerateStream(routing_id(),
+                                             next_ipc_id_++,
+                                             components,
+                                             security_origin));
+}
+
+void MediaStreamDispatcher::StopStream(const std::string &label) {
+  DCHECK_EQ(MessageLoop::current(), message_loop_);
+  VLOG(1) << "MediaStreamDispatcher::StopStream"
+          << ", {label = " << label;

[scherkus (not reviewing), 2011/06/17 17:42:13]

nit: you're not closing your { in your log message :)

[Per K, 2011/06/18 19:53:59]

Done.

+
+  LabelStreamMap::iterator it = label_stream_map_.find(label);
+  if (it == label_stream_map_.end())
+    return;
+
+  Send(new MediaStreamHostMsg_StopGeneratedStream(routing_id(), label));
+  label_stream_map_.erase(it);
+}
+
+bool MediaStreamDispatcher::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(MediaStreamDispatcher, message)
+    IPC_MESSAGE_HANDLER(MediaStreamMsg_StreamGenerated,
+                        OnStreamGenerated)
+    IPC_MESSAGE_HANDLER(MediaStreamMsg_StreamGenerationFailed,
+                        OnStreamGenerationFailed)
+    IPC_MESSAGE_HANDLER(MediaStreamHostMsg_VideoDeviceFailed,
+                        OnVideoDeviceFailed)
+    IPC_MESSAGE_HANDLER(MediaStreamHostMsg_AudioDeviceFailed,
+                        OnAudioDeviceFailed)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void MediaStreamDispatcher::OnStreamGenerated(
+    int request_id,
+    const std::string& label,
+    const media_stream::StreamDeviceInfoArray& audio_array,
+    const media_stream::StreamDeviceInfoArray& video_array) {
+
+  for (RequestList::iterator it = requests_.begin();
+       it != requests_.end(); ++it) {
+    Request& request = *it;
+    if (request.ipc_request == request_id) {
+      Stream new_stream;
+      new_stream.handler = request.handler;
+      new_stream.audio_array = audio_array;
+      new_stream.video_array = video_array;
+      label_stream_map_[label] = new_stream;
+      request.handler->OnStreamGenerated(request.request_id, label,
+                                         audio_array, video_array);
+      VLOG(1) << "MediaStreamDispatcher::OnStreamGenerated("
+              << request.request_id << ", " << label << ")";
+      requests_.erase(it);
+      break;
+    }
+  }
+}
+
+void MediaStreamDispatcher::OnStreamGenerationFailed(int request_id) {
+  for (RequestList::iterator it = requests_.begin();
+       it != requests_.end(); ++it) {
+    Request& request =  *it;

[scherkus (not reviewing), 2011/06/17 17:42:13]

nit: remove extra space

[Per K, 2011/06/18 19:53:59]

Done.

+    if (request.ipc_request == request_id) {
+      request.handler->OnStreamGenerationFailed(request.request_id);
+      VLOG(1) << "MediaStreamDispatcher::OnStreamGenerationFailed("
+              << request.request_id << ")\n";
+      requests_.erase(it);
+      break;
+    }
+  }
+}
+
+void MediaStreamDispatcher::OnVideoDeviceFailed(const std::string& label,
+                                                int index) {
+  LabelStreamMap::iterator it = label_stream_map_.find(label);
+  if (it == label_stream_map_.end())
+    return;
+
+  // index is the index in the video_array that have failed.
+  DCHECK_GT(it->second.video_array.size(), static_cast<size_t>(index));
+  media_stream::StreamDeviceInfoArray::iterator device_it =
+      it->second.video_array.begin();
+  it->second.video_array.erase(device_it + index);
+  it->second.handler->OnVideoDeviceFailed(label, index);
+}
+
+void MediaStreamDispatcher::OnAudioDeviceFailed(const std::string& label,
+                                                int index) {
+  LabelStreamMap::iterator it = label_stream_map_.find(label);
+  if (it == label_stream_map_.end())
+    return;
+
+  // index is the index in the audio_array that have failed.
+  DCHECK_GT(it->second.audio_array.size(), static_cast<size_t>(index));
+  media_stream::StreamDeviceInfoArray::iterator device_it =
+      it->second.audio_array.begin();
+  it->second.audio_array.erase(device_it + index);
+  it->second.handler->OnAudioDeviceFailed(label, index);
+}
+
+const media_stream::StreamDeviceInfoArray&
+MediaStreamDispatcher::audio_device_array(const std::string& label) {
+  DCHECK_EQ(MessageLoop::current(), message_loop_);
+  if (label.empty())
+    return empty_stream_array;
+
+  if (label_stream_map_.find(label) == label_stream_map_.end())
+    return empty_stream_array;
+
+  return label_stream_map_[label].audio_array;
+}
+
+const media_stream::StreamDeviceInfoArray&
+MediaStreamDispatcher::video_device_array(const std::string& label) {
+  DCHECK_EQ(MessageLoop::current(), message_loop_);
+  if (label.empty())
+    return empty_stream_array;
+
+  if (label_stream_map_.find(label) == label_stream_map_.end())
+    return empty_stream_array;
+
+  return label_stream_map_[label].video_array;
+}