Issue 7182004: infobars: Use TCW directly in InfoBar to remove the delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7182004: infobars: Use TCW directly in InfoBar to remove the delegate. (Closed)

Created:
9 years, 6 months ago by tfarina

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

infobars: Use TCW directly in InfoBar to remove the delegate. Note: This is a TODO in infobar.h for pkasting. BUG=None TEST=None R=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89285

Patch Set 1 : #

Patch Set 2 : #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -11 lines)			Patch
M	chrome/browser/tab_contents/infobar.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/infobar_container.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/infobar_container.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

r-, please do not attempt to make any substantive changes in the cross platform infobar ...

9 years, 6 months ago (2011-06-15 23:39:52 UTC) #2

tfarina

On 2011/06/15 23:39:52, Peter Kasting wrote: > r-, please do not attempt to make any ...

9 years, 6 months ago (2011-06-15 23:40:56 UTC) #3

Peter Kasting

On 2011/06/15 23:40:56, tfarina wrote: > Hum? Sorry? What is wrong with this? Don't touch ...

9 years, 6 months ago (2011-06-15 23:42:18 UTC) #4

Peter Kasting

9 years, 6 months ago (2011-06-15 23:45:04 UTC) #5

On 2011/06/15 23:42:18, Peter Kasting wrote:
> Don't touch the infobar code when I'm in the middle of what looks like it will
> be a year-long attempt to refactor it and have a lot of outstanding local
> changes.

Hmm, on second thought, this particular change is OK -- I can merge it locally
without too much trouble.  So LGTM on this.  But please don't worry about fixing
any other TODOs, I'm on top of it.

Expand Messages | Collapse Messages