Open Options page on top of NTP.

chrome/browser/ui/browser_navigator.cc

Index: chrome/browser/ui/browser_navigator.cc
diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc
index 7e01e615f61f920d3bdee21d24eb0b87b293ac07..d3a44ff63b5a941dd9c2d53e2b93d63b7db5ce4a 100644
--- a/chrome/browser/ui/browser_navigator.cc
+++ b/chrome/browser/ui/browser_navigator.cc
@@ -83,6 +83,10 @@ bool CompareURLsWithReplacements(
   return url_replaced == other_replaced;
 }
 
+}  // anonymous namespace

[James Hawkins, 2011/06/17 17:44:57]

s/anonymous namespace/namespace/

Technically it's an unnamed namespace, but as far as the style guide is
concerned, the closing comment should match the opening declaration, i.e.,
namespace.

[Greg Billock, 2011/06/17 21:16:07]

Done.

+
+namespace browser {
+
 // Returns the index of an existing singleton tab in |params->browser| matching
 // the URL specified in |params|.
 int GetIndexOfSingletonTab(browser::NavigateParams* params) {
@@ -127,6 +131,10 @@ int GetIndexOfSingletonTab(browser::NavigateParams* params) {
   return -1;
 }
 
+}  // namespace browser
+
+namespace {

[James Hawkins, 2011/06/17 17:44:57]

Why do we have two unnamed namespaces?

[Greg Billock, 2011/06/17 21:16:07]

Just so the diffs are easier to follow. I plan to move GetIndexOfSingletonTab
down next to Navigate.

+
 // Change some of the navigation parameters based on the particular URL.
 // Currently this applies to chrome://settings and the bookmark manager,
 // which we always want to open in a normal (not incognito) window. Guest