net: serialize SSL connection status to disk cache.

net: serialize SSL connection status to disk cache.

BUG=none
TEST=Check that the page info shown when clicking the green padlock includes ciphersuite information, even for cached pages.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89490

[agl, 2011-06-15 18:28:01]

This took about 60 seconds to fix and a long time to track down!

[wtc, 2011-06-16 17:46:31]

LGTM.

rvargas: just FYI because this is a change to the HTTP cache
code.

http://codereview.chromium.org/7177001/diff/1/net/http/http_response_info.cc
File net/http/http_response_info.cc (left):

http://codereview.chromium.org/7177001/diff/1/net/http/http_response_info.cc#...
net/http/http_response_info.cc:201: // TODO(wtc): we should persist
ssl_info.connection_status.
I'm sorry I knew about this bug but it fell through the cracks.

http://codereview.chromium.org/7177001/diff/1/net/http/http_response_info.cc
File net/http/http_response_info.cc (right):

http://codereview.chromium.org/7177001/diff/1/net/http/http_response_info.cc#...
net/http/http_response_info.cc:61: // This contains the ciphersuite of used to
fetch the resource.
Nit: remove "of"

Nit: the SSL connection status contains other info, such as
the SSL protocol version, compression method and whether
SSLv3 fallback occurred.

[commit-bot: I haz the power, 2011-06-17 15:48:18]

Change committed as 89490