Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: webkit/fileapi/file_system_operation_write_unittest.cc

Issue 7174002: Change {Obfuscated|Local}FileSystemFileUtil non-Singleton to take an underlying *FileUtil. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed memery leak at LocalFSFUTest, and rebased. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_operation_write_unittest.cc
diff --git a/webkit/fileapi/file_system_operation_write_unittest.cc b/webkit/fileapi/file_system_operation_write_unittest.cc
index b07985953722881fc43114c656c79ccf757a1529..90f69f572709b853e12708546dfd69fa3bf16401 100644
--- a/webkit/fileapi/file_system_operation_write_unittest.cc
+++ b/webkit/fileapi/file_system_operation_write_unittest.cc
@@ -29,6 +29,7 @@
#include "webkit/fileapi/file_system_test_helper.h"
#include "webkit/fileapi/file_system_util.h"
#include "webkit/fileapi/local_file_system_file_util.h"
+#include "webkit/fileapi/quota_file_util.h"
#include "webkit/quota/quota_manager.h"
using quota::QuotaManager;
@@ -97,6 +98,7 @@ class FileSystemOperationWriteTest : public testing::Test {
return test_helper_.GetURLForPath(path);
}
+ scoped_ptr<LocalFileSystemFileUtil> local_file_util_;
scoped_refptr<MockQuotaManager> quota_manager_;
FileSystemTestOriginHelper test_helper_;
@@ -183,12 +185,14 @@ void FileSystemOperationWriteTest::SetUp() {
ASSERT_TRUE(dir_.CreateUniqueTempDir());
FilePath base_dir = dir_.path().AppendASCII("filesystem");
+ local_file_util_.reset(
+ new LocalFileSystemFileUtil(QuotaFileUtil::GetInstance()));
quota_manager_ = new MockQuotaManager(base_dir, 1024);
test_helper_.SetUp(base_dir,
false /* incognito */,
false /* unlimited quota */,
quota_manager_->proxy(),
- LocalFileSystemFileUtil::GetInstance());
+ local_file_util_.get());
filesystem_dir_ = test_helper_.GetOriginRootPath();
ASSERT_TRUE(file_util::CreateTemporaryFileInDir(filesystem_dir_, &file_));
@@ -201,6 +205,7 @@ void FileSystemOperationWriteTest::TearDown() {
net::URLRequest::RegisterProtocolFactory("blob", NULL);
quota_manager_ = NULL;
test_helper_.TearDown();
+ local_file_util_.reset();
}
FileSystemOperation* FileSystemOperationWriteTest::operation() {

Powered by Google App Engine
This is Rietveld 408576698