Change {Obfuscated|Local}FileSystemFileUtil non-Singleton to take an underlying *FileUtil.

webkit/fileapi/file_system_path_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_FILE_SYSTEM_PATH_MANAGER_H_
 #define WEBKIT_FILEAPI_FILE_SYSTEM_PATH_MANAGER_H_
 #pragma once
 
 #include "base/callback_old.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/quota/special_storage_policy.h"
 
 class GURL;
 
 namespace base {
 class MessageLoopProxy;
 }
 
 namespace fileapi {
 
 class ExternalFileSystemMountPointProvider;
 class FileSystemFileUtil;
+class LocalFileSystemFileUtil;
 class SandboxMountPointProvider;
 
 class FileSystemPathManager {
  public:
   FileSystemPathManager(
       scoped_refptr<base::MessageLoopProxy> file_message_loop,
       const FilePath& profile_path,
       scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy,
       bool is_incognito,
       bool allow_file_access_from_files);
@@ skipping 53 matching lines @@
     return external_provider_.get();
   }
 
   bool is_incognito() const {
     return is_incognito_;
   }
 
  private:
   const bool is_incognito_;
   const bool allow_file_access_from_files_;
+  scoped_ptr<LocalFileSystemFileUtil> local_file_util_;

[ericu, 2011/06/17 20:32:07]

This seems odd.  Why should a FileSystemPathManager own a FSFU subclass
directly?  Shouldn't it be the external_provider_ that takes care of this, just
as the SandboxMountPointProvider supplies the one for the sandbox?

[Dai Mikurube (NOT FULLTIME), 2011/06/23 08:13:32]

Agreed.  It's better for the FSFU instance in MountPointProvider.  Moved it to
CrosMountPointProvider.

But actually, GetFileSystemFileUtil() in FileSystemPathManager and
MountPointProvider looks like a little strange to me.  My thought is "Which
-FileUtil to be used" doesn't depend only on the GURL path.  What do you think?
(I think it'll be in another issue even if we decide to change it.)

   scoped_ptr<SandboxMountPointProvider> sandbox_provider_;
   scoped_ptr<ExternalFileSystemMountPointProvider> external_provider_;
 
   DISALLOW_COPY_AND_ASSIGN(FileSystemPathManager);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_FILE_SYSTEM_PATH_MANAGER_H_