Change {Obfuscated|Local}FileSystemFileUtil non-Singleton to take an underlying *FileUtil.

webkit/fileapi/local_file_system_file_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_FILE_UTIL_H_
 #define WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_FILE_UTIL_H_
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/file_util_proxy.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"

[kinuko, 2011/07/05 06:35:24]

nit: not necessary?

[Dai Mikurube (NOT FULLTIME), 2011/07/05 08:05:40]

Done.

-#include "base/memory/singleton.h"
 #include "base/platform_file.h"
 #include "base/tracked_objects.h"

[kinuko, 2011/07/05 06:35:24]

nit: not necessary?

[Dai Mikurube (NOT FULLTIME), 2011/07/05 08:05:40]

Done.

 #include "webkit/fileapi/file_system_file_util.h"
 #include "webkit/fileapi/file_system_types.h"
 
 namespace base {
 struct PlatformFileInfo;
 class MessageLoopProxy;
 class Time;
 }
 
 class GURL;
 
 namespace fileapi {
 
 using base::PlatformFile;
 using base::PlatformFileError;
 
 class FileSystemOperationContext;
 
+// Now, this class is created and owned only by *MountPointProvider and tests.

[kinuko, 2011/07/05 06:35:24]

wording nit: 'Now, ' and 'only' is not needed I think?  ('and tests.' at the end
might be dropped as well)
wording nit: this class is -> an instance of this class is

[Dai Mikurube (NOT FULLTIME), 2011/07/05 08:05:40]

Done.

 class LocalFileSystemFileUtil : public FileSystemFileUtil {
  public:
-  static LocalFileSystemFileUtil* GetInstance();
+  // |underlying_file_util| is not owned by the instance.  It will need to be
+  // a singleton or to be deleted by someone else.
+  explicit LocalFileSystemFileUtil(FileSystemFileUtil* underlying_file_util);
 
   virtual PlatformFileError CreateOrOpen(
       FileSystemOperationContext* context,
       const FilePath& file_path,
       int file_flags,
       PlatformFile* file_handle,
       bool* created);
 
   virtual PlatformFileError EnsureFileExists(
       FileSystemOperationContext* context,
@@ skipping 61 matching lines @@
 
   virtual bool IsDirectoryEmpty(
       FileSystemOperationContext* context,
       const FilePath& file_path);
 
   virtual AbstractFileEnumerator* CreateFileEnumerator(
       FileSystemOperationContext* context,
       const FilePath& root_path);
 
  protected:
-  LocalFileSystemFileUtil() { }
-
-  friend struct DefaultSingletonTraits<LocalFileSystemFileUtil>;
   DISALLOW_COPY_AND_ASSIGN(LocalFileSystemFileUtil);

[kinuko, 2011/07/05 06:35:24]

nit: why is this placed here?  can we move this into private?

[Dai Mikurube (NOT FULLTIME), 2011/07/05 08:05:40]

Done.

 
  private:
   // Given the filesystem's root URL and a virtual path, produces a real, full
   // local path.
   FilePath GetLocalPath(
       FileSystemOperationContext* context,
       const GURL& origin_url,
       FileSystemType type,
       const FilePath& virtual_path);
+
+  FileSystemFileUtil* underlying_file_util_;
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_LOCAL_FILE_SYSTEM_FILE_UTIL_H_