Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: src/variables.cc

Issue 7172030: Revert "Merge arguments branch to bleeding merge." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/variables.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 UNREACHABLE(); 50 UNREACHABLE();
51 return NULL; 51 return NULL;
52 } 52 }
53 53
54 54
55 Property* Variable::AsProperty() const { 55 Property* Variable::AsProperty() const {
56 return rewrite_ == NULL ? NULL : rewrite_->AsProperty(); 56 return rewrite_ == NULL ? NULL : rewrite_->AsProperty();
57 } 57 }
58 58
59 59
60 Slot* Variable::AsSlot() const { return rewrite_; } 60 Slot* Variable::AsSlot() const {
61 return rewrite_ == NULL ? NULL : rewrite_->AsSlot();
62 }
61 63
62 64
63 bool Variable::IsStackAllocated() const { 65 bool Variable::IsStackAllocated() const {
64 return rewrite_ != NULL && rewrite_->IsStackAllocated(); 66 Slot* slot = AsSlot();
67 return slot != NULL && slot->IsStackAllocated();
65 } 68 }
66 69
67 70
68 bool Variable::IsParameter() const { 71 bool Variable::IsParameter() const {
69 return rewrite_ != NULL && rewrite_->type() == Slot::PARAMETER; 72 Slot* s = AsSlot();
73 return s != NULL && s->type() == Slot::PARAMETER;
70 } 74 }
71 75
72 76
73 bool Variable::IsStackLocal() const { 77 bool Variable::IsStackLocal() const {
74 return rewrite_ != NULL && rewrite_->type() == Slot::LOCAL; 78 Slot* s = AsSlot();
79 return s != NULL && s->type() == Slot::LOCAL;
75 } 80 }
76 81
77 82
78 bool Variable::IsContextSlot() const { 83 bool Variable::IsContextSlot() const {
79 return rewrite_ != NULL && rewrite_->type() == Slot::CONTEXT; 84 Slot* s = AsSlot();
85 return s != NULL && s->type() == Slot::CONTEXT;
80 } 86 }
81 87
82 88
83 Variable::Variable(Scope* scope, 89 Variable::Variable(Scope* scope,
84 Handle<String> name, 90 Handle<String> name,
85 Mode mode, 91 Mode mode,
86 bool is_valid_LHS, 92 bool is_valid_LHS,
87 Kind kind) 93 Kind kind)
88 : scope_(scope), 94 : scope_(scope),
89 name_(name), 95 name_(name),
90 mode_(mode), 96 mode_(mode),
91 kind_(kind), 97 kind_(kind),
92 local_if_not_shadowed_(NULL), 98 local_if_not_shadowed_(NULL),
93 rewrite_(NULL), 99 rewrite_(NULL),
94 is_valid_LHS_(is_valid_LHS), 100 is_valid_LHS_(is_valid_LHS),
95 is_accessed_from_inner_scope_(false), 101 is_accessed_from_inner_scope_(false),
96 is_used_(false) { 102 is_used_(false) {
97 // names must be canonicalized for fast equality checks 103 // names must be canonicalized for fast equality checks
98 ASSERT(name->IsSymbol()); 104 ASSERT(name->IsSymbol());
99 } 105 }
100 106
101 107
102 bool Variable::is_global() const { 108 bool Variable::is_global() const {
103 // Temporaries are never global, they must always be allocated in the 109 // Temporaries are never global, they must always be allocated in the
104 // activation frame. 110 // activation frame.
105 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope(); 111 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope();
106 } 112 }
107 113
108 } } // namespace v8::internal 114 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/variables.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698