Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: PRESUBMIT.py

Issue 7172014: Fix presubmit check to not enforce git-try to be parsed as python (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for depot tools. 5 """Top-level presubmit script for depot tools.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 14 matching lines...) Expand all
25 25
26 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) 26 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
27 black_list = list(input_api.DEFAULT_BLACK_LIST) + [ 27 black_list = list(input_api.DEFAULT_BLACK_LIST) + [
28 r'^cpplint\.py$', 28 r'^cpplint\.py$',
29 r'^python_bin[\/\\].+', 29 r'^python_bin[\/\\].+',
30 r'^svn_bin[\/\\].+', 30 r'^svn_bin[\/\\].+',
31 r'^tests[\/\\]\w+?[\/\\].+'] 31 r'^tests[\/\\]\w+?[\/\\].+']
32 results.extend(input_api.canned_checks.RunPylint( 32 results.extend(input_api.canned_checks.RunPylint(
33 input_api, 33 input_api,
34 output_api, 34 output_api,
35 white_list=[r'.*\.py$', r'^git-try$'], 35 white_list=[r'.*\.py$'],
36 black_list=black_list)) 36 black_list=black_list))
37 37
38 # TODO(maruel): Make sure at least one file is modified first. 38 # TODO(maruel): Make sure at least one file is modified first.
39 # TODO(maruel): If only tests are modified, only run them. 39 # TODO(maruel): If only tests are modified, only run them.
40 results.extend(input_api.canned_checks.RunUnitTestsInDirectory( 40 results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
41 input_api, 41 input_api,
42 output_api, 42 output_api,
43 'tests', 43 'tests',
44 whitelist=[r'.*test\.py$'])) 44 whitelist=[r'.*test\.py$']))
45 results.extend(RunGitClTests(input_api, output_api)) 45 results.extend(RunGitClTests(input_api, output_api))
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 return CommonChecks(input_api, output_api) 98 return CommonChecks(input_api, output_api)
99 99
100 100
101 def CheckChangeOnCommit(input_api, output_api): 101 def CheckChangeOnCommit(input_api, output_api):
102 output = [] 102 output = []
103 output.extend(CommonChecks(input_api, output_api)) 103 output.extend(CommonChecks(input_api, output_api))
104 output.extend(input_api.canned_checks.CheckDoNotSubmit( 104 output.extend(input_api.canned_checks.CheckDoNotSubmit(
105 input_api, 105 input_api,
106 output_api)) 106 output_api))
107 return output 107 return output
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698