Make name and message non-enumerable on Error object (this is a partial fix for issue 1215)

test/mjsunit/error-constructors.js

Index: test/mjsunit/error-constructors.js
===================================================================
--- test/mjsunit/error-constructors.js	(revision 8295)
+++ test/mjsunit/error-constructors.js	(working copy)
@@ -59,3 +59,24 @@
 ReferenceError.prototype.name = "not a reference error";
 assertEquals("ReferenceError", ReferenceError.prototype.name);
 
+// Check that message and name are not enumerable on Error objects.
+var desc = Object.getOwnPropertyDescriptor(Error.prototype, 'name');
+assertFalse(desc['enumerable']);
+desc = Object.getOwnPropertyDescriptor(Error.prototype, 'message');
+assertFalse(desc['enumerable']);
+
+var e = new Error("foobar");
+desc = Object.getOwnPropertyDescriptor(e, 'message');
+assertFalse(desc['enumerable']);
+desc = Object.getOwnPropertyDescriptor(e, 'arguments');
+assertFalse(desc['enumerable']);
+desc = Object.getOwnPropertyDescriptor(e, 'type');
+assertFalse(desc['enumerable']);
+desc = Object.getOwnPropertyDescriptor(e, 'stack');
+assertFalse(desc['enumerable']);
+
+// Name is not an own property, test that it is not enumerable by running
+// through all properties of e.
+for (var v in e) {

[Mads Ager (chromium), 2011/06/15 13:41:54]

Error objects should have no enumerable properties at this point, right? So you
could even assertUnreachable unconditionally in the body. Maybe some of the code
above prevents that? In that case, move this up so you can do it?

[Rico, 2011/06/15 13:54:33]

Done, but I kept the assertions above (to guarantee that the properties are
actually there)

+  if (v == 'name') assertUnreachable();
+}