Make name and message non-enumerable on Error object (this is a partial fix for issue 1215)

Make name and message non-enumerable on Error object (this is a partial fix for issue 1215)
Committed: http://code.google.com/p/v8/source/detail?r=8299

[Mads Ager (chromium), 2011-06-15 12:05:21]

If we make name and message not enumerable, shouldn't we do that for the other
properties on error instances as well?

> var e = new Error("asdf")
> for (var n in e) print(n)
arguments
type
message
stack
name

[Rico, 2011-06-15 12:36:02]

Patch updated with all non-enumerable properties. We now follow safari and
Firefox nightly (except that firefox has the non spec lineNumber and fileName as
enumerable properties)

[Mads Ager (chromium), 2011-06-15 13:41:54]

LGTM

http://codereview.chromium.org/7172011/diff/4001/test/mjsunit/error-construct...
File test/mjsunit/error-constructors.js (right):

http://codereview.chromium.org/7172011/diff/4001/test/mjsunit/error-construct...
test/mjsunit/error-constructors.js:80: for (var v in e) {
Error objects should have no enumerable properties at this point, right? So you
could even assertUnreachable unconditionally in the body. Maybe some of the code
above prevents that? In that case, move this up so you can do it?

[Rico, 2011-06-15 13:54:33]

http://codereview.chromium.org/7172011/diff/4001/test/mjsunit/error-construct...
File test/mjsunit/error-constructors.js (right):

http://codereview.chromium.org/7172011/diff/4001/test/mjsunit/error-construct...
test/mjsunit/error-constructors.js:80: for (var v in e) {
On 2011/06/15 13:41:54, Mads Ager wrote:
> Error objects should have no enumerable properties at this point, right? So
you
> could even assertUnreachable unconditionally in the body. Maybe some of the
code
> above prevents that? In that case, move this up so you can do it?
Done, but I kept the assertions above (to guarantee that the properties are
actually there)