Prepare push to trunk.

Prepare push to trunk.
Committed: http://code.google.com/p/v8/source/detail?r=8291

[Mads Ager (chromium), 2011-06-15 09:15:22]

Please cut down on the ChangeLog. Have a look at the other entries in the file.
We usually only list the changes that have a direct impact on the embedder
(critical bug fixes, changes to the API). For a complete change log googlecode
can be used.

[Søren Thygesen Gjesse, 2011-06-15 09:19:45]

LGTM, with comments

I think you should trim down the list. We try to only put stuff in the change
log which is of interest to embedders to give them an idea of whether it makes
sense for them to update.

http://codereview.chromium.org/7171015/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode6
ChangeLog:6: performance of the latter construct.
Maybe change this to "Improve performance of try/catch" (leave out internal
details).

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode11
ChangeLog:11: Makefiles for all architectures on Linux.
Maybe shorten this to just "Added support for building Xcode project files from
GYP files"

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode16
ChangeLog:16: Implemented core support for FixedDoubleArrays.
Remove this - only internal.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode18
ChangeLog:18: Fixed a bug where an array load was incorrectly hoisted by GVN.
I assume there is no issue for this.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode24
ChangeLog:24: to 63.
I assume there is no issue for this.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode26
ChangeLog:26: Removed the --debug-info flag and behave like its value is true.
Please remove this.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode34
ChangeLog:34: Skip test-debug/DebuggerAgent on ARM. (issue 945)
Also remove this.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode40
ChangeLog:40: code.
Also remove this.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode42
ChangeLog:42: Do not redefine properties unneccesarily in seal and freeze.
(issue 1447)
Long line.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode45
ChangeLog:45: expects one now.
Also remove this.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode50
ChangeLog:50: Small valgrind fix.
Also remove this.

[Sven Panne, 2011-06-15 09:37:01]

I think the policy what to put into the ChangeLog is not 100% clear: My
understanding is that every externally visible change (API, flags, bug fixes,
...) are documented. "things of interest to embedders" is a bit to fuzzy IMHO.

http://codereview.chromium.org/7171015/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode6
ChangeLog:6: performance of the latter construct.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Maybe change this to "Improve performance of try/catch" (leave out internal
> details).

Done.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode11
ChangeLog:11: Makefiles for all architectures on Linux.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Maybe shorten this to just "Added support for building Xcode project files
from
> GYP files"

Done, but I think it makes sense to leave the other 2 changes in the
description.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode16
ChangeLog:16: Implemented core support for FixedDoubleArrays.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Remove this - only internal.

Done.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode18
ChangeLog:18: Fixed a bug where an array load was incorrectly hoisted by GVN.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> I assume there is no issue for this.

I assumed the same, at least it was not mentioned in the commit message.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode24
ChangeLog:24: to 63.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> I assume there is no issue for this.

See above. :)

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode26
ChangeLog:26: Removed the --debug-info flag and behave like its value is true.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Please remove this.

Why? Isn't this an externally visible change?

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode34
ChangeLog:34: Skip test-debug/DebuggerAgent on ARM. (issue 945)
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Also remove this.

Done.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode40
ChangeLog:40: code.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Also remove this.

Done.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode42
ChangeLog:42: Do not redefine properties unneccesarily in seal and freeze.
(issue 1447)
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Long line.

Done.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode45
ChangeLog:45: expects one now.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Also remove this.

I think this has to be in the ChangeLog, because it is an API change in v8.h,
too.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode50
ChangeLog:50: Small valgrind fix.
On 2011/06/15 09:19:45, Søren Gjesse wrote:
> Also remove this.

Done.

[Søren Thygesen Gjesse, 2011-06-15 09:46:39]

LGTM

http://codereview.chromium.org/7171015/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode26
ChangeLog:26: Removed the --debug-info flag and behave like its value is true.
On 2011/06/15 09:37:01, Sven wrote:
> On 2011/06/15 09:19:45, Søren Gjesse wrote:
> > Please remove this.
> 
> Why? Isn't this an externally visible change?

It is, but I don't think it is relevant (I did not try, but running with
--nodebug-info would most likely break stuff).

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode45
ChangeLog:45: expects one now.
On 2011/06/15 09:37:01, Sven wrote:
> On 2011/06/15 09:19:45, Søren Gjesse wrote:
> > Also remove this.
> 
> I think this has to be in the ChangeLog, because it is an API change in v8.h,
> too.

Oh, sorry. Then I think the line should say that the API
IsExecutionTerminating() now might need an isolate

[Sven Panne, 2011-06-15 09:57:46]

http://codereview.chromium.org/7171015/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode26
ChangeLog:26: Removed the --debug-info flag and behave like its value is true.
On 2011/06/15 09:46:39, Søren Gjesse wrote:
> On 2011/06/15 09:37:01, Sven wrote:
> > On 2011/06/15 09:19:45, Søren Gjesse wrote:
> > > Please remove this.
> > 
> > Why? Isn't this an externally visible change?
> 
> It is, but I don't think it is relevant (I did not try, but running with
> --nodebug-info would most likely break stuff).

OK, I'll remove it then.

http://codereview.chromium.org/7171015/diff/1/ChangeLog#newcode45
ChangeLog:45: expects one now.
On 2011/06/15 09:46:39, Søren Gjesse wrote:
> On 2011/06/15 09:37:01, Sven wrote:
> > On 2011/06/15 09:19:45, Søren Gjesse wrote:
> > > Also remove this.
> > 
> > I think this has to be in the ChangeLog, because it is an API change in
v8.h,
> > too.
> 
> Oh, sorry. Then I think the line should say that the API
> IsExecutionTerminating() now might need an isolate

Done.