Issue 7171005: Always support locating Chromium-branded builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7171005: Always support locating Chromium-branded builds. (Closed)

Created:
9 years, 6 months ago by cmp

Modified:
9 years, 5 months ago

Reviewers:
darin (slow to review), jrt

CC:
chromium-reviews, Paweł Hajdan Jr., jrt-google

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Always support locating Chromium-branded builds.

Patch Set 1 #

Patch Set 2 : disable chrome switching in UIPerfTest and PageCyclerReferenceTest #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -2 lines)			Patch
M	chrome/common/chrome_constants.cc	View		2 chunks	+42 lines, -0 lines	0 comments	Download
M	chrome/test/page_cycler/page_cycler_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/ui/ui_perf_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/ui/ui_test.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View		3 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cmp

This is a POC showing what I have in mind to fix the official-branded-test-exe running ...

9 years, 6 months ago (2011-06-15 00:42:07 UTC) #1

cmp

Darin mentions Joe Tessler, his 2010 summer intern, will take this over. Joe, feel free ...

9 years, 6 months ago (2011-06-16 20:17:27 UTC) #2

jrt

9 years, 6 months ago (2011-06-16 22:41:58 UTC) #3

On 2011/06/16 20:17:27, cmp wrote:
> Darin mentions Joe Tessler, his 2010 summer intern, will take this over.  Joe,
> feel free to take this and run with it and let me know if you have any
> questions.

New issue here: http://codereview.chromium.org/7185023

Expand Messages | Collapse Messages