Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7170022: Fix NaCl system header files location (Closed)

Created:
9 years, 6 months ago by eaeltsin
Modified:
9 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Fix NaCl system header files location NATIVE_SYSTEM_HEADER_DIR is target makefile variable that describes where system headers are located, relative to file system root. Default is /usr/include. When building a cross-compiler configured using --with-sysroot, CROSS_SYSTEM_HEADER_DIR is constructed from sysroot value followed by NATIVE_SYSTEM_HEADER_DIR. We don’t have /usr/include on NaCl, so set this to /include. This only affects configurations that use --with-sysroot, so the actual effect will become visible only when I add --with-sysroot to gcc configuration. R=pasko@google.com BUG=http://code.google.com/p/nativeclient/issues/detail?id=854 TEST= Committed: http://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=1b292e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gcc/config/i386/t-nacl64 View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eaeltsin
9 years, 6 months ago (2011-06-15 17:21:37 UTC) #1
pasko-google - do not use
9 years, 6 months ago (2011-06-15 17:43:03 UTC) #2
LGTM

please, also, provide explanation of:
1. why GCC cross-compiler searches sys-include
2. how NATIVE_SYSTEM_HEADER_DIR is converted to CROSS_SYSTEM_HEADER_DIR
3. GCC algorithm to search for limits.h

.. you could also clarify that with the next change you'd eliminate sys-include
to cleanup the tools/Makefile

Powered by Google App Engine
This is Rietveld 408576698