Fix to bug 75303

Fix to bug 75303
Makes the sun_path an absolute path("/tmp/pipe_name") to allow IPC between processes with different working directories 
BUG=75303
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90400

[sanjeevr, 2011-06-20 21:50:34]

http://codereview.chromium.org/7167017/diff/2001/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

http://codereview.chromium.org/7167017/diff/2001/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:148: PathService::Get(base::DIR_TEMP, &temp_dir);
Document why this is needed.

http://codereview.chromium.org/7167017/diff/2001/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:149: std::string pipe_path= temp_dir.value()+ "/" +
pipe_name;
Use FilePath::Append instead of appending the string manually.

[sanjeevr, 2011-06-20 22:27:26]

LGTM with some style nits. Also adding dmac as a reviewer. Dave, can you quickly
take a look at this and make sure it looks OK?

http://codereview.chromium.org/7167017/diff/6001/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

http://codereview.chromium.org/7167017/diff/6001/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:147: //Convert relative path of named pipe to absolute
path
Style nit: You need a space after the //. Same below.

http://codereview.chromium.org/7167017/diff/6001/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:151: std::string pipe_path=
temp_dir.Append(pipe_name).value();
Style nit: You need a space before the =

[dmac, 2011-06-20 22:30:23]

LGTM with some small style nits.

http://codereview.chromium.org/7167017/diff/6001/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

http://codereview.chromium.org/7167017/diff/6001/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:236: //Convert relative path of named pipe to absolute
path
spaces after //

http://codereview.chromium.org/7167017/diff/6001/ipc/ipc_channel_posix.cc#new...
ipc/ipc_channel_posix.cc:240: std::string pipe_path=
temp_dir.Append(pipe_name).value();
space before =

[sanjeevr, 2011-06-23 22:34:14]

LGTM

http://codereview.chromium.org/7167017/diff/10001/ipc/ipc_channel_handle.h
File ipc/ipc_channel_handle.h (right):

http://codereview.chromium.org/7167017/diff/10001/ipc/ipc_channel_handle.h#ne...
ipc/ipc_channel_handle.h:33: // The name that is passed in should be an absolute
path.
This comment is only for Posix.

[commit-bot: I haz the power, 2011-06-24 18:57:25]

Change committed as 90400