Issue 7167016: Revert 87047 - Revert 86422 - Make DHCP WPAD on by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7167016: Revert 87047 - Revert 86422 - Make DHCP WPAD on by default. (Closed)

Created:
9 years, 6 months ago by Jói

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 87047 - Revert 86422 - Make DHCP WPAD on by default. Reason: Turning back on for trunk to collect data as performance worries are addressed. BUG=18575, 84047 TEST=Run Chrome on Windows without any flags. Enable auto-detect in proxy configuration. Net log should show attempts to auto-detect via DHCP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89486

Patch Set 1 #

Patch Set 2 : merge #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
M	chrome/browser/net/connection_tester.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/net/proxy_service_factory.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	net/proxy/dhcp_proxy_script_fetcher_factory.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/proxy/dhcp_proxy_script_fetcher_factory.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói

Wan-Teh, this is a straight revert, just turning DHCP WPAD back on on trunk so ...

9 years, 6 months ago (2011-06-15 19:58:45 UTC) #2

Jói

wtc: gentle ping On Wed, Jun 15, 2011 at 3:58 PM, <joi@chromium.org> wrote: > Wan-Teh, ...

9 years, 6 months ago (2011-06-16 18:48:44 UTC) #3

LGTM.

Expand Messages | Collapse Messages