Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: content/renderer/media/audio_message_filter_unittest.cc

Issue 7157001: Implements AudioMessageFilter as member in RenderThread (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Fixed nits in AudioRenderImpl unit test Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/audio_message_filter.cc ('k') | content/renderer/media/audio_renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_message_filter_unittest.cc
===================================================================
--- content/renderer/media/audio_message_filter_unittest.cc (revision 92113)
+++ content/renderer/media/audio_message_filter_unittest.cc (working copy)
@@ -92,8 +92,7 @@
TEST(AudioMessageFilterTest, Basic) {
MessageLoop message_loop(MessageLoop::TYPE_IO);
- const int kRouteId = 0;
- scoped_refptr<AudioMessageFilter> filter(new AudioMessageFilter(kRouteId));
+ scoped_refptr<AudioMessageFilter> filter(new AudioMessageFilter());
MockAudioDelegate delegate;
int stream_id = filter->AddDelegate(&delegate);
@@ -103,8 +102,7 @@
AudioBuffersState buffers_state(kSizeInBuffer, 0);
EXPECT_FALSE(delegate.request_packet_received());
- filter->OnMessageReceived(AudioMsg_RequestPacket(
- kRouteId, stream_id, buffers_state));
+ filter->OnMessageReceived(AudioMsg_RequestPacket(stream_id, buffers_state));
EXPECT_TRUE(delegate.request_packet_received());
EXPECT_EQ(kSizeInBuffer, delegate.buffers_state().pending_bytes);
EXPECT_EQ(0, delegate.buffers_state().hardware_delay_bytes);
@@ -114,8 +112,7 @@
// AudioMsg_NotifyStreamStateChanged
EXPECT_FALSE(delegate.state_changed_received());
filter->OnMessageReceived(
- AudioMsg_NotifyStreamStateChanged(kRouteId, stream_id,
- kAudioStreamPlaying));
+ AudioMsg_NotifyStreamStateChanged(stream_id, kAudioStreamPlaying));
EXPECT_TRUE(delegate.state_changed_received());
EXPECT_TRUE(kAudioStreamPlaying == delegate.state());
delegate.Reset();
@@ -124,8 +121,7 @@
const uint32 kLength = 1024;
EXPECT_FALSE(delegate.created_received());
filter->OnMessageReceived(
- AudioMsg_NotifyStreamCreated(kRouteId,
- stream_id,
+ AudioMsg_NotifyStreamCreated(stream_id,
base::SharedMemory::NULLHandle(),
kLength));
EXPECT_TRUE(delegate.created_received());
@@ -137,7 +133,7 @@
const double kVolume = 1.0;
EXPECT_FALSE(delegate.volume_received());
filter->OnMessageReceived(
- AudioMsg_NotifyStreamVolume(kRouteId, stream_id, kVolume));
+ AudioMsg_NotifyStreamVolume(stream_id, kVolume));
EXPECT_TRUE(delegate.volume_received());
EXPECT_EQ(kVolume, delegate.volume());
delegate.Reset();
@@ -148,8 +144,7 @@
TEST(AudioMessageFilterTest, Delegates) {
MessageLoop message_loop(MessageLoop::TYPE_IO);
- const int kRouteId = 0;
- scoped_refptr<AudioMessageFilter> filter(new AudioMessageFilter(kRouteId));
+ scoped_refptr<AudioMessageFilter> filter(new AudioMessageFilter());
MockAudioDelegate delegate1;
MockAudioDelegate delegate2;
@@ -161,7 +156,7 @@
EXPECT_FALSE(delegate1.request_packet_received());
EXPECT_FALSE(delegate2.request_packet_received());
filter->OnMessageReceived(
- AudioMsg_RequestPacket(kRouteId, stream_id1, AudioBuffersState()));
+ AudioMsg_RequestPacket(stream_id1, AudioBuffersState()));
EXPECT_TRUE(delegate1.request_packet_received());
EXPECT_FALSE(delegate2.request_packet_received());
delegate1.Reset();
@@ -169,28 +164,22 @@
EXPECT_FALSE(delegate1.request_packet_received());
EXPECT_FALSE(delegate2.request_packet_received());
filter->OnMessageReceived(
- AudioMsg_RequestPacket(kRouteId, stream_id2, AudioBuffersState()));
+ AudioMsg_RequestPacket(stream_id2, AudioBuffersState()));
EXPECT_FALSE(delegate1.request_packet_received());
EXPECT_TRUE(delegate2.request_packet_received());
delegate2.Reset();
- // Send a message of a different route id, a message is not received.
- EXPECT_FALSE(delegate1.request_packet_received());
- filter->OnMessageReceived(
- AudioMsg_RequestPacket(kRouteId + 1, stream_id1, AudioBuffersState()));
- EXPECT_FALSE(delegate1.request_packet_received());
-
// Remove the delegates. Make sure they won't get called.
filter->RemoveDelegate(stream_id1);
EXPECT_FALSE(delegate1.request_packet_received());
filter->OnMessageReceived(
- AudioMsg_RequestPacket(kRouteId, stream_id1, AudioBuffersState()));
+ AudioMsg_RequestPacket(stream_id1, AudioBuffersState()));
EXPECT_FALSE(delegate1.request_packet_received());
filter->RemoveDelegate(stream_id2);
EXPECT_FALSE(delegate2.request_packet_received());
filter->OnMessageReceived(
- AudioMsg_RequestPacket(kRouteId, stream_id2, AudioBuffersState()));
+ AudioMsg_RequestPacket(stream_id2, AudioBuffersState()));
EXPECT_FALSE(delegate2.request_packet_received());
message_loop.RunAllPending();
« no previous file with comments | « content/renderer/media/audio_message_filter.cc ('k') | content/renderer/media/audio_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698