Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: content/renderer/media/audio_message_filter.h

Issue 7157001: Implements AudioMessageFilter as member in RenderThread (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Fixed nits in AudioRenderImpl unit test Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_message_filter.h
===================================================================
--- content/renderer/media/audio_message_filter.h (revision 92113)
+++ content/renderer/media/audio_message_filter.h (working copy)
@@ -4,7 +4,7 @@
//
// MessageFilter that handles audio messages and delegates them to audio
// renderers. Created on render thread, AudioMessageFilter is operated on
-// IO thread (main thread of render process), it intercepts audio messages
+// IO thread (secondary thread of render process) it intercepts audio messages
// and process them on IO thread since these messages are time critical.
#ifndef CONTENT_RENDERER_MEDIA_AUDIO_MESSAGE_FILTER_H_
@@ -52,7 +52,7 @@
virtual ~Delegate() {}
};
- explicit AudioMessageFilter(int32 route_id);
+ AudioMessageFilter();
virtual ~AudioMessageFilter();
// Add a delegate to the map and return id of the entry.
@@ -64,12 +64,7 @@
// Sends an IPC message using |channel_|.
bool Send(IPC::Message* message);
- MessageLoop* message_loop() { return message_loop_; }
-
private:
- // For access to |message_loop_|.
- friend class AudioRendererImplTest;
-
FRIEND_TEST_ALL_PREFIXES(AudioMessageFilterTest, Basic);
FRIEND_TEST_ALL_PREFIXES(AudioMessageFilterTest, Delegates);
@@ -80,8 +75,7 @@
virtual void OnChannelClosing();
// Received when browser process wants more audio packet.
- void OnRequestPacket(const IPC::Message& msg, int stream_id,
- AudioBuffersState buffers_state);
+ void OnRequestPacket(int stream_id, AudioBuffersState buffers_state);
// Received when browser process has created an audio output stream.
void OnStreamCreated(int stream_id, base::SharedMemoryHandle handle,
@@ -110,10 +104,6 @@
IPC::Channel* channel_;
- int32 route_id_;
-
- MessageLoop* message_loop_;
-
DISALLOW_COPY_AND_ASSIGN(AudioMessageFilter);
};
« no previous file with comments | « content/renderer/media/audio_input_message_filter.cc ('k') | content/renderer/media/audio_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698