Implements AudioMessageFilter as member in RenderThread

content/renderer/media/audio_message_filter.cc

Index: content/renderer/media/audio_message_filter.cc
===================================================================
--- content/renderer/media/audio_message_filter.cc	(revision 90030)
+++ content/renderer/media/audio_message_filter.cc	(working copy)
@@ -9,16 +9,16 @@
 #include "content/common/media/audio_messages.h"
 #include "ipc/ipc_logging.h"
 
-AudioMessageFilter::AudioMessageFilter(int32 route_id)
+AudioMessageFilter::AudioMessageFilter()
     : channel_(NULL),
-      route_id_(route_id),
       message_loop_(NULL) {
+  VLOG(1) << "AudioMessageFilter::AudioMessageFilter()";
 }
 
 AudioMessageFilter::~AudioMessageFilter() {
+  VLOG(1) << "AudioMessageFilter::~AudioMessageFilter()";
 }
 
-// Called on the IPC thread.
 bool AudioMessageFilter::Send(IPC::Message* message) {
   if (!channel_) {
     delete message;
@@ -33,14 +33,10 @@
     return true;
   }
 
-  message->set_routing_id(route_id_);
   return channel_->Send(message);
 }
 
 bool AudioMessageFilter::OnMessageReceived(const IPC::Message& message) {
-  if (message.routing_id() != route_id_)
-    return false;
-
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AudioMessageFilter, message)
     IPC_MESSAGE_HANDLER(AudioMsg_RequestPacket, OnRequestPacket)
@@ -55,6 +51,7 @@
 }
 
 void AudioMessageFilter::OnFilterAdded(IPC::Channel* channel) {
+  VLOG(1) << "AudioMessageFilter::OnFilterAdded()";
   // Captures the message loop for IPC.
   message_loop_ = MessageLoop::current();

[jam, 2011/06/23 18:59:55]

sorry I know this isn't part of this change, but you don't need to keep a
pointer to the IO message loop. just do
ChildProcess::current()->io_message_loop

[scherkus (not reviewing), 2011/06/23 19:14:43]

It's think this code might have been around before ChildProcess had such methods
:)

I agree w/ the change though!

[henrika_dont_use, 2011/06/27 15:05:44]

Removed, but the unit tests sets the message_loop_ member.
Will start up a separate discussion regarding the unit test.

On 2011/06/23 18:59:55, John Abd-El-Malek wrote:

[henrika_dont_use, 2011/06/27 15:05:44]

Done.

   channel_ = channel;
@@ -68,8 +65,7 @@
   channel_ = NULL;
 }
 
-void AudioMessageFilter::OnRequestPacket(const IPC::Message& msg,
-                                         int stream_id,
+void AudioMessageFilter::OnRequestPacket(int stream_id,
                                          AudioBuffersState buffers_state) {
   Delegate* delegate = delegates_.Lookup(stream_id);
   if (!delegate) {