Implements AudioMessageFilter as member in RenderThread

content/renderer/media/audio_message_filter_creator.cc

Index: content/renderer/media/audio_message_filter_creator.cc
===================================================================
--- content/renderer/media/audio_message_filter_creator.cc	(revision 0)
+++ content/renderer/media/audio_message_filter_creator.cc	(revision 0)
@@ -0,0 +1,23 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/audio_message_filter_creator.h"
+
+#include "content/renderer/media/audio_message_filter.h"
+
+AudioMessageFilterCreator::AudioMessageFilterCreator() {
+  filter_ = new AudioMessageFilter();
+}
+
+AudioMessageFilterCreator::~AudioMessageFilterCreator() {}
+
+// static
+AudioMessageFilter* AudioMessageFilterCreator::SharedFilter() {
+  return GetInstance()->filter_.get();
+}
+
+// static
+AudioMessageFilterCreator* AudioMessageFilterCreator::GetInstance() {
+  return Singleton<AudioMessageFilterCreator>::get();

[scherkus (not reviewing), 2011/06/16 21:56:22]

hmmmmmmmm.... I'm wondering....

is there any reason to not use Singleton<AudioMessageFilter>::get() as opposed
to this creator class?

guess I'm a bit confused

I'm also wondering about whether classes should be injecting the
AudioMessageFilter as opposed to calling the singleton directly (just concerned
about testability... singletons usually harm testability)

[henrika_dont_use, 2011/06/17 11:52:02]

Good point. I agree (used same approach as was done for video) and will modify
the design. Creator class is removed. Using new factory design in
AudioMessageFilter instead.

On 2011/06/16 21:56:22, scherkus wrote:

+}
Property changes on: content\renderer\media\audio_message_filter_creator.cc
___________________________________________________________________
Added: svn:eol-style
   + LF