Save net-internals log dumps directly to disk.

chrome/browser/resources/net_internals/dataview.js

Index: chrome/browser/resources/net_internals/dataview.js
===================================================================
--- chrome/browser/resources/net_internals/dataview.js	(revision 89253)
+++ chrome/browser/resources/net_internals/dataview.js	(working copy)
@@ -13,8 +13,8 @@
  *  @constructor
  */
 function DataView(mainBoxId,
-                  outputTextBoxId,
-                  exportTextButtonId,
+                  downloadIframeId,
+                  exportFileButtonId,
                   securityStrippingCheckboxId,
                   byteLoggingCheckboxId,
                   passivelyCapturedCountId,
@@ -27,8 +27,6 @@
                   loggingTextSpanId) {
   DivView.call(this, mainBoxId);
 
-  this.textPre_ = document.getElementById(outputTextBoxId);
-
   var securityStrippingCheckbox =
       document.getElementById(securityStrippingCheckboxId);
   securityStrippingCheckbox.onclick =
@@ -38,9 +36,11 @@
   byteLoggingCheckbox.onclick =
       this.onSetByteLogging_.bind(this, byteLoggingCheckbox);
 
-  var exportTextButton = document.getElementById(exportTextButtonId);
-  exportTextButton.onclick = this.onExportToText_.bind(this);
+  this.downloadIframe_ = document.getElementById(downloadIframeId);
 
+  this.exportFileButton_ = document.getElementById(exportFileButtonId);
+  this.exportFileButton_.onclick = this.onExportToText_.bind(this);
+
   this.activelyCapturedCountBox_ =
       document.getElementById(activelyCapturedCountId);
   this.passivelyCapturedCountBox_ =
@@ -58,7 +58,6 @@
       this.logFileChanged.bind(this, loadLogFileElement);
 
   this.updateEventCounts_();
-  this.waitingForUpdate_ = false;
 
   g_browser.addLogObserver(this);
 }
@@ -96,7 +95,6 @@
   setNodeDisplay(this.dumpDataDiv_, !isViewingLogFile);
   setNodeDisplay(this.capturingTextSpan_, !isViewingLogFile);
   setNodeDisplay(this.loggingTextSpan_, isViewingLogFile);
-  this.setText_('');
 };
 
 /**
@@ -130,12 +128,8 @@
   g_browser.setSecurityStripping(securityStrippingCheckbox.checked);
 };
 
-/**
- * Clears displayed text when security stripping is toggled.
- */
 DataView.prototype.onSecurityStrippingChanged = function() {
-  this.setText_('');
-}
+};
 
 /**
  * Called when a log file is selected.
@@ -152,31 +146,35 @@
 
     fileReader.readAsText(logFile);
   }
-}
+};
 
 /**
  * Displays an error message when unable to read the selected log file.
  */
 DataView.prototype.onLoadLogFileError = function(event) {
   alert('Error ' + event.target.error.code + '.  Unable to load file.');
-}
+};
 
 /**
  * Tries to load the contents of the log file.
  */
 DataView.prototype.onLoadLogFile = function(event) {
   g_browser.loadedLogFile(event.target.result);
-}
+};
 
+DataView.prototype.enableExportFileButton_ = function(enabled) {
+  this.exportFileButton_.disabled = !enabled;
+};
+
 /**
  * If not already waiting for results from all updates, triggers all
  * updates and starts waiting for them to complete.
  */
 DataView.prototype.onExportToText_ = function() {
-  if (this.waitingForUpdate_)
+  if (this.exportFileButton_.disabled)
     return;
-  this.waitingForUpdate = true;
-  this.setText_('Generating...');
+  this.enableExportFileButton_(false);
+
   g_browser.updateAllInfo(this.onUpdateAllCompleted.bind(this));
 };
 
@@ -404,12 +402,68 @@
     }
   }
 
-  // Open a new window to display this text.
-  this.setText_(text.join('\n'));
+  var flatText = text.join('\n');
+  // Use Windows-style line breaks under Windows, so text file can be viewed
+  // with notepad.
+  if (g_browser.isPlatformWindows())
+    flatText.replace(/\n/g, '\r\n');

[eroman, 2011/06/16 19:16:45]

I suspect the file API might have something similar to "text mode" for files,
which does the conversion transparently.

This is fine though.

[mmenke, 2011/06/16 19:23:55]

Specs don't seem to mention it.  I could see it using mime type, but as we want
to force a download, anyways, can't use text/plain.

[kinuko, 2011/06/17 08:00:16]

BlobBuilder has some support for line-ending conversion.  I think you can use
"native" in this case.

http://dev.w3.org/2009/dap/file-system/file-writer.html#widl-BlobBuilder-appe...

[mmenke, 2011/06/17 13:45:59]

Tried it, and it works.

 
-  this.selectText_();
+  var blobBuilder = new WebKitBlobBuilder();
+  blobBuilder.append(flatText);
+  var textBlob = blobBuilder.getBlob('octet/stream');
+
+  window.webkitRequestFileSystem(
+      window.TEMPORARY, 10*1024 + textBlob.size,

[eroman, 2011/06/16 19:16:45]

what is the 10kb padding for?

[mmenke, 2011/06/16 19:23:55]

The file API doesn't specify what the size actually means.  I don't trust it to
not include some sort of padding, or file index, etc.  10 KB is a little small
for that, though, I suppose.

[kinuko, 2011/06/17 08:00:16]

For now this 'size' has no significant meaning but in the future this might be
used to request some quota for the filesystem.  For now any reasonable number
should work as far as you're using TEMPORARY filesystem.  (Or you'll just get
quota error when the physical disk is really getting tight)

[mmenke, 2011/06/17 13:45:59]

Ok.  I'll just go ahead and remove the 10 kB, then.

+      this.onFileSystemCreate_.bind(this, textBlob),
+      this.onFileError_.bind(this, 'Unable to create file system.'));
 };
 
+// Once we have access to the file system, create a log file.
+DataView.prototype.onFileSystemCreate_ = function(textBlob, fileSystem) {
+  fileSystem.root.getFile(
+      'net_internals_log.txt', {create: true},
+      this.onFileCreate_.bind(this, textBlob),
+      this.onFileError_.bind(this, 'Unable to create file.'));
+};
+
+// Once the file is created, or an existing one has been opened, create a
+// writer for it.
+DataView.prototype.onFileCreate_ = function(textBlob, fileEntry) {
+  fileEntry.createWriter(
+      this.onFileCreateWriter_.bind(this, textBlob, fileEntry),
+      this.onFileError_.bind(this, 'Unable to create writer.'));
+};
+
+// Once the |fileWriter| has been created, truncate the file, in case it already
+// existed.
+DataView.prototype.onFileCreateWriter_ = function(textBlob,
+                                                  fileEntry, fileWriter) {
+  fileWriter.onerror = this.onFileError_.bind(this, 'Truncate failed.');
+  fileWriter.onwriteend = this.onFileTruncate_.bind(this, textBlob,
+                                                    fileWriter, fileEntry);
+  fileWriter.truncate(0);
+};
+
+// Once the file has been truncated, write |textBlob| to the file.
+DataView.prototype.onFileTruncate_ = function(textBlob, fileWriter, fileEntry) {
+  fileWriter.onerror = this.onFileError_.bind(this, 'Write failed.');
+  fileWriter.onwriteend = this.onFileWriteComplete_.bind(this, fileEntry);
+  fileWriter.write(textBlob);
+};
+
+// Once the file has been written to, start the download.
+DataView.prototype.onFileWriteComplete_ = function(fileEntry) {
+  this.downloadIframe_.src = fileEntry.toURL();
+  this.enableExportFileButton_(true);
+};
+
+// On any Javascript File API error, enable the export button and display
+// |errorText|, followed by the specific error.
+DataView.prototype.onFileError_ = function(errorText, error) {
+  this.enableExportFileButton_(true);
+  alert(errorText + '  ' + getKeyWithValue(FileError, error.code));
+};
+
 DataView.prototype.appendEventsPrintedAsText_ = function(out) {
   var allEvents = g_browser.getAllCapturedEvents();
 
@@ -480,14 +534,6 @@
 };
 
 /**
- * Helper function to set this view's content to |text|.
- */
-DataView.prototype.setText_ = function(text) {
-  this.textPre_.innerHTML = '';
-  addTextNode(this.textPre_, text);
-};
-
-/**
  * Format a time ticks count as a timestamp.
  */
 DataView.prototype.formatExpirationTime_ = function(timeTicks) {
@@ -495,15 +541,3 @@
   var isExpired = d.getTime() < (new Date()).getTime();
   return 't=' + d.getTime() + (isExpired ? ' [EXPIRED]' : '');
 };
-
-/**
- * Select all text from log dump.
- */
-DataView.prototype.selectText_ = function() {
-  var selection = window.getSelection();
-  selection.removeAllRanges();
-
-  var range = document.createRange();
-  range.selectNodeContents(this.textPre_);
-  selection.addRange(range);
-};