Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 7155: Fix bug where a shelf or infobar would not be closed correctly when closing a... (Closed)

Created:
12 years, 2 months ago by Glen Murphy
Modified:
9 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix bug where a shelf or infobar would not be closed correctly when closing a tab. The issue was because ShelfVisibilityChangedImpl is called twice, once with a null current_tab for the closing tab (via TabClosingAt), and once on selection of the new tab (via TabSelectedAt) - the first call nulls the shelves without doing a Layout, the nulled shelves then don't show up in the second call, so Layout is never called. http://crbug.com/2069 BUG=2069 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3528

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M chrome/browser/views/old_frames/vista_frame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/old_frames/vista_frame.cc View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/views/old_frames/xp_frame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/old_frames/xp_frame.cc View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Glen Murphy
12 years, 2 months ago (2008-10-14 22:59:53 UTC) #1
sky
12 years, 2 months ago (2008-10-14 23:22:54 UTC) #2
LGTM once you add the initialize for needs_layout_.

http://codereview.chromium.org/7155/diff/1/4
File chrome/browser/views/old_frames/vista_frame.h (right):

http://codereview.chromium.org/7155/diff/1/4#newcode385
Line 385: bool needs_layout_;
Don't forget to set this in the member initializer (or Init).

Powered by Google App Engine
This is Rietveld 408576698