Issue 7150010: Distinguish keyed loads with a symbol key from fast elements loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7150010: Distinguish keyed loads with a symbol key from fast elements loads. (Closed)

Created:
9 years, 6 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Distinguish keyed loads with a symbol key from fast elements loads. This change fixes the deoptimization when a keyed load is used with a symbol key. Before we would wrongly generate a fast elements load. Now we generate a generic keyed load instead. BUG=1471 Committed: http://code.google.com/p/v8/source/detail?r=8281

Patch Set 1 #

Patch Set 2 : fixed lint error #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
M	src/ast.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/type-info.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/type-info.cc	View	1 2 3	3 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/7150010/diff/4003/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/7150010/diff/4003/src/type-info.cc#newcode77 src/type-info.cc:77: bool TypeFeedbackOracle::LoadIsMonomorphic(Property* expr) { Maybe rename this function ...

9 years, 6 months ago (2011-06-14 12:45:26 UTC) #3

fschneider

I fixed the case for stores as well. Please have another look.

9 years, 6 months ago (2011-06-14 13:15:29 UTC) #4

LGTM

Expand Messages | Collapse Messages