Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider.cc

Issue 7149017: Cleanup OriginIdentifierValueMap code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_pref_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_pref_provider.cc b/chrome/browser/content_settings/content_settings_pref_provider.cc
index 072dbb656a6d07ccfa628786e4650ca590b4e5bb..ddd13c250ec25a2a5a7379c68c9fbebe8fb6cf05 100644
--- a/chrome/browser/content_settings/content_settings_pref_provider.cc
+++ b/chrome/browser/content_settings/content_settings_pref_provider.cc
@@ -602,8 +602,8 @@ void PrefProvider::ResetToDefaults() {
{
base::AutoLock auto_lock(lock_);
- value_map_.Clear();
- incognito_value_map_.Clear();
+ value_map_.clear();
+ incognito_value_map_.clear();
}
if (!is_incognito_) {
@@ -639,7 +639,7 @@ void PrefProvider::ClearAllContentSettingsRules(
std::string pattern_str = CreatePatternString(
entry->item_pattern, entry->top_level_frame_pattern);
// Delete current |entry| and set |entry| to the next value map entry.
- entry = map_to_modify->DeleteValue(entry);
+ entry = map_to_modify->erase(entry);
// Update the content settings preference.
if (all_settings_dictionary) {
@@ -718,7 +718,7 @@ void PrefProvider::ReadExceptions(bool overwrite) {
prefs->GetDictionary(prefs::kContentSettingsPatterns);
if (overwrite)
- value_map_.Clear();
+ value_map_.clear();
updating_preferences_ = true;
// Careful: The returned value could be NULL if the pref has never been set.
« no previous file with comments | « chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698