Correctly set ReadOnly flag on indexed properties when using the API Set method (fixes issue 1470)

test/cctest/test-api.cc

Index: test/cctest/test-api.cc
===================================================================
--- test/cctest/test-api.cc	(revision 8275)
+++ test/cctest/test-api.cc	(working copy)
@@ -14480,3 +14480,20 @@
   TryCatch try_catch;
   CompileRun("f.call(2)");
 }
+
+
+// Regression test for issue 1470.
+THREADED_TEST(ReadOnlyIndexedProperties) {
+  v8::HandleScope scope;
+  Local<ObjectTemplate> templ = ObjectTemplate::New();
+
+  LocalContext context;
+  Local<v8::Object> obj = templ->NewInstance();
+  context->Global()->Set(v8_str("obj"), obj);
+  obj->Set(v8_str("1"), v8_str("DONT_CHANGE"), v8::ReadOnly);
+  obj->Set(v8_str("1"), v8_str("foobar"));
+  CHECK_EQ(v8_str("DONT_CHANGE"), obj->Get(v8_str("1")));
+  obj->Set(v8_num(2), v8_str("DONT_CHANGE"), v8::ReadOnly);
+  obj->Set(v8_num(2), v8_str("foobar"));

[Erik Corry, 2011/06/14 13:21:51]

Can we haz a test with a string that represents an out-of-Smi-range integer?

[Rico, 2011/06/14 13:44:23]

Done.

+  CHECK_EQ(v8_str("DONT_CHANGE"), obj->Get(v8_num(2)));
+}