Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 7149013: Remove most of the remaining test dependencies (other than chrome/test). (Closed)

Created:
9 years, 6 months ago by jam
Modified:
9 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

Remove most of the remaining test dependencies (other than chrome/test). I moved FindPasteboard since it seemed like a core dependency of the clipboard APIs. I left its test behind because I didn't think we'd want to move cocoa_test_helper.h to content? I moved all the testing URLRequestObjects to content, since we'll want to have stuff like that for content tests. BUG=76697 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89063

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1007 lines) Patch
M chrome/browser/automation/automation_resource_message_filter.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/browser_encoding_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/save_package_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/errorpage_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/net/url_request_failed_dns_job.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/net/url_request_failed_dns_job.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/net/url_request_mock_http_job.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/net/url_request_mock_http_job.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/browser/net/url_request_mock_link_doctor_job.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/net/url_request_mock_net_error_job.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/net/url_request_mock_net_error_job.cc View 1 chunk +0 lines, -125 lines 0 comments Download
M chrome/browser/net/url_request_mock_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/browser/net/url_request_slow_download_job.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/net/url_request_slow_download_job.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/net/url_request_slow_http_job.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/net/url_request_slow_http_job.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/find_pasteboard.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/ui/cocoa/find_pasteboard.mm View 1 chunk +0 lines, -82 lines 0 comments Download
M chrome/browser/ui/cocoa/find_pasteboard_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/unload_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/npapi_interactive_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
A + content/browser/find_pasteboard.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/find_pasteboard.mm View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/net/url_request_failed_dns_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/net/url_request_failed_dns_job.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/net/url_request_mock_http_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/net/url_request_mock_http_job.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/net/url_request_mock_net_error_job.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/net/url_request_mock_net_error_job.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/net/url_request_slow_download_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/net/url_request_slow_download_job.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/net/url_request_slow_http_job.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/net/url_request_slow_http_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/clipboard_message_filter_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 6 months ago (2011-06-14 06:28:14 UTC) #1
Avi (use Gerrit)
LGTM
9 years, 6 months ago (2011-06-14 13:53:29 UTC) #2
willchan no longer on Chromium
9 years, 6 months ago (2011-06-14 20:15:35 UTC) #3
On 2011/06/14 13:53:29, Avi wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld 408576698