build/debug.xcconfig - Issue 7149: improve layout tests by removing definition of DEBUG (libxml uses it to spew ...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/debug.xcconfig

Issue 7149: improve layout tests by removing definition of DEBUG (libxml uses it to spew ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 12 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "common.xcconfig"	5 #include "common.xcconfig"

6	6

7 COPY_PHASE_STRIP = NO	7 COPY_PHASE_STRIP = NO

8 GCC_OPTIMIZATION_LEVEL = 0	8 GCC_OPTIMIZATION_LEVEL = 0

9 GCC_PREPROCESSOR_DEFINITIONS = $(GCC_PREPROCESSOR_DEFINITIONS) DEBUG	9 // Would be nice to define DEBUG to prevent against people incorrectly defining

	10 // it intstead of !NDEBUG, but it causes libxml to spew diagnostic info all

	11 // over our layout tests.

	12 // GCC_PREPROCESSOR_DEFINITIONS = $(GCC_PREPROCESSOR_DEFINITIONS) DEBUG

10 // Additional libc++ strictness; disabled because they break some things in	13 // Additional libc++ strictness; disabled because they break some things in

11 // WebKit and some additional things when building with gcc 4.2.	14 // WebKit and some additional things when building with gcc 4.2.

12 // GCC_PREPROCESSOR_DEFINITIONS = $(GCC_PREPROCESSOR_DEFINITIONS) DEBUG _GLIBCXX _CONCEPT_CHECKS _GLIBCXX_DEBUG _GLIBCXX_DEBUG_PEDANTIC	15 // GCC_PREPROCESSOR_DEFINITIONS = $(GCC_PREPROCESSOR_DEFINITIONS) DEBUG _GLIBCXX _CONCEPT_CHECKS _GLIBCXX_DEBUG _GLIBCXX_DEBUG_PEDANTIC

13 OTHER_CFLAGS = $(OTHER_CFLAGS) -fstack-protector -fstack-protector-all	16 OTHER_CFLAGS = $(OTHER_CFLAGS) -fstack-protector -fstack-protector-all

14	17

15 // Code coverage support via gcov is disabled for normal debug builds because	18 // Code coverage support via gcov is disabled for normal debug builds because

16 // our build structure results in many "merge mismatch for summaries" messages	19 // our build structure results in many "merge mismatch for summaries" messages

17 // being printed at the conclusion of many tests in many depend build cases, as	20 // being printed at the conclusion of many tests in many depend build cases, as

18 // well as a long delay while summary data is written. Since these are not	21 // well as a long delay while summary data is written. Since these are not

19 // needed in the majority of debug builds, code coverage is left off, but it	22 // needed in the majority of debug builds, code coverage is left off, but it

20 // can be easily enabled by uncommenting the next section.	23 // can be easily enabled by uncommenting the next section.

21 //	24 //

22 //GCC_GENERATE_TEST_COVERAGE_FILES = YES	25 //GCC_GENERATE_TEST_COVERAGE_FILES = YES

23 //GCC_INSTRUMENT_PROGRAM_FLOW_ARCS = YES	26 //GCC_INSTRUMENT_PROGRAM_FLOW_ARCS = YES

24 //CODECOVERAGE_OTHER_LDFLAGS = -lgcov	27 //CODECOVERAGE_OTHER_LDFLAGS = -lgcov

OLD	NEW