Issue 7148014: Ensure that bound functions does not have a prototype (fixes issue 794)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7148014: Ensure that bound functions does not have a prototype (fixes issue 794) (Closed)

Created:
9 years, 6 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Ensure that bound functions does not have a prototype (fixes issue 794) Committed: http://code.google.com/p/v8/source/detail?r=8293

Patch Set 4 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -5 lines)			Patch
M	src/objects.h	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 2	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/v8natives.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/function-bind.js	View	1 2	3 chunks	+2 lines, -3 lines	0 comments	Download
A	test/mjsunit/regress/regress-794.js	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Rico

Since constructor calls on functions without a prototype is not allowed I had to change ...

9 years, 6 months ago (2011-06-15 07:08:11 UTC) #3

Lasse Reichstein

LGTM. http://codereview.chromium.org/7148014/diff/5001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/7148014/diff/5001/src/objects.h#newcode4600 src/objects.h:4600: // Indicates whether the function is a native ...

9 years, 6 months ago (2011-06-15 09:48:54 UTC) #4

Rico

9 years, 6 months ago (2011-06-15 10:34:45 UTC) #5

http://codereview.chromium.org/7148014/diff/5001/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/7148014/diff/5001/src/objects.h#newcode4600
src/objects.h:4600: // Indicates whether the function is a native function.
On 2011/06/15 09:48:54, Lasse Reichstein wrote:
> Comment is a copy of the one for native(). It needs to be rewritten to match.

Done.

Expand Messages | Collapse Messages

Issue 7148014: Ensure that bound functions does not have a prototype (fixes issue 794) (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages