Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 7147016: Need to strip the config result value otherwise it contains a \n. (Closed)

Created:
9 years, 6 months ago by M-A Ruel
Modified:
9 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Need to strip the config result value otherwise it contains a \n. It was broken in 88979. Someone my limited testing missed that. TBR=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 6 months ago (2011-06-14 13:32:13 UTC) #1
Dirk Pranke
9 years, 6 months ago (2011-06-14 17:42:36 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698