Move user cloud policy to BrowserProcess (was 6979011)

chrome/browser/policy/cloud_policy_subsystem_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/policy/configuration_policy_pref_store.h"

[Joao da Silva, 2011/06/22 12:51:30]

Nit: header order

[gfeher, 2011/06/22 19:18:34]

Done.

 #include "chrome/browser/policy/cloud_policy_identity_strategy.h"
+#include "chrome/browser/policy/cloud_policy_provider_impl.h"
 #include "chrome/browser/policy/logging_work_scheduler.h"
 #include "chrome/browser/policy/mock_configuration_policy_store.h"
 #include "chrome/browser/policy/proto/cloud_policy.pb.h"
 #include "chrome/browser/policy/proto/device_management_backend.pb.h"
 #include "chrome/browser/policy/testing_cloud_policy_subsystem.h"
 #include "chrome/browser/policy/testing_policy_url_fetcher_factory.h"
 #include "chrome/browser/policy/user_policy_cache.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/testing_browser_process.h"
 #include "chrome/test/testing_pref_service.h"
@@ skipping 122 matching lines @@
     cloud_policy_subsystem_->Shutdown();
     cloud_policy_subsystem_.reset();
     factory_.reset();
     logger_.reset();
     prefs_.reset();
   }
 
   // Verifies for a given policy that it is provided by the subsystem.
   void VerifyPolicy(enum ConfigurationPolicyType type, Value* expected) {
     MockConfigurationPolicyStore store;
+    CloudPolicyProviderImpl provider(
+        policy::ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
+        CloudPolicyCacheBase::POLICY_LEVEL_MANDATORY);
+    provider.AppendCache(cache_);
     EXPECT_CALL(store, Apply(_, _)).Times(AtLeast(1));
-    cache_->GetManagedPolicyProvider()->Provide(&store);
+    provider.Provide(&store);

[Mattias Nissler (ping if slow), 2011/06/21 20:09:56]

can't you just get the policy map from the cache and check that?

[gfeher, 2011/06/22 19:18:34]

Done.

     ASSERT_TRUE(Value::Equals(expected, store.Get(type)));
   }
 
   // Verifies that the last recorded run of the subsystem did not issue
   // too frequent requests:
   // - no more than 10 requests in the first 10 minutes
   // - no more then 12 requests per hour in the next 10 hours
   // TODO(gfeher): Thighten these conditions further. This will require
   // fine-tuning of the subsystem. See: http://crosbug.com/15195
   void VerifyServerLoad() {
@@ skipping 129 matching lines @@
   EXPECT_CALL(*(factory_.get()), Intercept(kGaiaAuthHeader, "register", _)).
       WillOnce(CreateSuccessfulRegisterResponse(kDMToken));
 
   EXPECT_CALL(*(factory_.get()), Intercept(kDMAuthHeader, "policy", _)).
       WillOnce(CreateSuccessfulPolicyResponse("http://www.example.com"));
 
   ExecuteTest("http://www.example.com");
 }
 
 }  // policy