Move user cloud policy to BrowserProcess (was 6979011)

chrome/browser/policy/cloud_policy_provider_impl.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_POLICY_CLOUD_POLICY_PROVIDER_IMPL_H_
+#define CHROME_BROWSER_POLICY_CLOUD_POLICY_PROVIDER_IMPL_H_
+#pragma once
+
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
+#include "base/observer_list.h"
+#include "chrome/browser/policy/cloud_policy_cache_base.h"
+#include "chrome/browser/policy/cloud_policy_provider.h"
+#include "chrome/browser/policy/policy_map.h"
+
+namespace policy {
+
+// A policy provider having multiple backend caches, combining their relevant
+// PolicyMaps and keeping the result cached. The underlying caches are kept as
+// weak references and can be added  dynamically. Also the
+// |CloudPolicyProvider| instance listens to cache-notifications and removes
+// the caches automatically when they go away. The order in which the caches are
+// stored matters! The first cache is applied as is and the following caches
+// only contribute the not-yet applied policies. There are two functions to add
+// a new cache:
+//   PrependCache(cache): adds |cache| to the front (i.e. most important cache).
+//   AppendCache(cache):  adds |cache| to the back (i.e. least important cache).

[Mattias Nissler (ping if slow), 2011/06/21 20:09:56]

It doesn't make sense to duplicate this comment.

[gfeher, 2011/06/22 19:18:34]

Done.

+class CloudPolicyProviderImpl : public CloudPolicyProvider,
+                                public CloudPolicyCacheBase::Observer {
+ public:
+  CloudPolicyProviderImpl(const PolicyDefinitionList* policy_list,
+                          CloudPolicyCacheBase::PolicyLevel level);
+  virtual ~CloudPolicyProviderImpl();
+
+  // ConfigurationPolicyProvider implementation.
+  virtual bool Provide(ConfigurationPolicyStoreInterface* store) OVERRIDE;
+  virtual bool IsInitializationComplete() const OVERRIDE;
+  virtual void AddObserver(ConfigurationPolicyProvider::Observer* observer)
+      OVERRIDE;
+  virtual void RemoveObserver(ConfigurationPolicyProvider::Observer* observer)
+      OVERRIDE;
+
+  // CloudPolicyCacheBase::Observer implementation.
+  virtual void OnCacheUpdate(CloudPolicyCacheBase* cache) OVERRIDE;
+  virtual void OnCacheGoingAway(CloudPolicyCacheBase* cache) OVERRIDE;
+
+  // Adds a new instance of CloudPolicyCacheBase to the end of |caches_|.
+  // Does not take ownership of |cache| and listens to OnCacheGoingAway to
+  // automatically remove it from |caches_|.

[Mattias Nissler (ping if slow), 2011/06/21 20:09:56]

don't need duplicate comments, but please put an override comment.

[gfeher, 2011/06/22 19:18:34]

It already has an OVERRIDE macro, isn't that enough?

+  virtual void AppendCache(CloudPolicyCacheBase* cache) OVERRIDE;
+
+  // Adds a new instance of CloudPolicyCacheBase to the beginning of |caches_|.
+  // Does not take ownership of |cache| and listens to OnCacheGoingAway to
+  // automatically remove it from |caches_|.

[Mattias Nissler (ping if slow), 2011/06/21 20:09:56]

same here.

[gfeher, 2011/06/22 19:18:34]

Done.

+  virtual void PrependCache(CloudPolicyCacheBase* cache) OVERRIDE;
+
+ private:
+  friend class CloudPolicyProviderTest;
+
+  // Detecting proxy-policies since they need a special handling when combining

[Mattias Nissler (ping if slow), 2011/06/21 20:09:56]

need a special -> need special

[gfeher, 2011/06/22 19:18:34]

Done.

+  // policy maps.
+  static ConfigurationPolicyType proxy_policies[];
+  static bool is_proxy_policy(ConfigurationPolicyType policy);
+  static unsigned int proxy_policy_count();
+  // Combines two PolicyMap and stores the result in out_map. The policies in
+  // |base| take precedence over the policies in |overlay|. Proxy policies are
+  // only applied in groups, that is if at least one proxy policy is present in
+  // |base| then no proxy related policy of |overlay| will be applied.
+  void CombineTwoPolicyMaps(const PolicyMap& base,

[Mattias Nissler (ping if slow), 2011/06/21 20:09:56]

can this be static?

[gfeher, 2011/06/22 19:18:34]

Done.

+                            const PolicyMap& overlay,
+                            PolicyMap* out_map);
+
+  // Recompute |combined_| from |caches_| and trigger an OnUpdatePolicy if
+  // something changed. This is called whenever a change in one of the caches
+  // is observed. For i=0..n-1: |caches_[i]| will contribute all its policies
+  // except those already provided by |caches_[0]|..|caches_[i-1]|. Proxy
+  // related policies are handled as a special case: they are only applied in
+  // groups.
+  void RecombineCachesAndMaybeTriggerUpdate();
+
+  // The underlying policy caches.
+  typedef std::vector<CloudPolicyCacheBase*> ListType;
+  ListType caches_;
+
+  // Policy level this provider will handle.
+  CloudPolicyCacheBase::PolicyLevel level_;
+
+  // Provider observers that are registered with this provider.
+  ObserverList<ConfigurationPolicyProvider::Observer, true> observer_list_;
+
+  // The currently valid combination of all the maps in |caches_|. Will be
+  // applied as is on call of Provide.
+  PolicyMap combined_;
+
+  DISALLOW_COPY_AND_ASSIGN(CloudPolicyProviderImpl);
+};
+
+}  // namespace policy
+
+#endif  // CHROME_BROWSER_POLICY_CLOUD_POLICY_PROVIDER_IMPL_H_