Move user cloud policy to BrowserProcess (was 6979011)

chrome/browser/policy/cloud_policy_controller_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/cloud_policy_controller.h"
 
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
+#include "chrome/browser/policy/cloud_policy_provider_impl.h"
+#include "chrome/browser/policy/configuration_policy_pref_store.h"
 #include "chrome/browser/policy/device_management_service.h"
 #include "chrome/browser/policy/device_token_fetcher.h"
 #include "chrome/browser/policy/logging_work_scheduler.h"
 #include "chrome/browser/policy/mock_configuration_policy_store.h"
 #include "chrome/browser/policy/mock_device_management_backend.h"
 #include "chrome/browser/policy/mock_device_management_service.h"
 #include "chrome/browser/policy/policy_notifier.h"
 #include "chrome/browser/policy/proto/device_management_backend.pb.h"
 #include "chrome/browser/policy/user_policy_cache.h"
 #include "content/browser/browser_thread.h"
@@ skipping 60 matching lines @@
   CloudPolicyControllerTest()
       : ui_thread_(BrowserThread::UI, &loop_),
         file_thread_(BrowserThread::FILE, &loop_) {}
 
   virtual ~CloudPolicyControllerTest() {}
 
   virtual void SetUp() {
     ASSERT_TRUE(temp_user_data_dir_.CreateUniqueTempDir());
     cache_.reset(new UserPolicyCache(
         temp_user_data_dir_.path().AppendASCII("CloudPolicyControllerTest")));
+    mandatory_cloud_provider_.reset(new CloudPolicyProviderImpl(
+        policy::ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
+        CloudPolicyCacheBase::POLICY_LEVEL_MANDATORY));
+    recommended_cloud_provider_.reset(new CloudPolicyProviderImpl(
+        policy::ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
+        CloudPolicyCacheBase::POLICY_LEVEL_RECOMMENDED));
+    mandatory_cloud_provider_->AppendCache(cache_.get());
+    recommended_cloud_provider_->AppendCache(cache_.get());

[Mattias Nissler (ping if slow), 2011/06/21 20:09:56]

As mentioned earlier, I think we should just remove the providers here and check
the PolicyMap directly, since the subject of this test is CloudPolicController
and not CloudPolicyProvider.

[gfeher, 2011/06/22 19:18:34]

Done.

     token_fetcher_.reset(new MockDeviceTokenFetcher(cache_.get()));
     service_.set_backend(&backend_);
   }
 
   virtual void TearDown() {
     controller_.reset();  // Unregisters observers.
   }
 
   // Takes ownership of |backend|.
   void CreateNewController() {
     controller_.reset(new CloudPolicyController(
         &service_, cache_.get(), token_fetcher_.get(), &identity_strategy_,
         &notifier_, new DummyWorkScheduler));
   }
 
   void ExpectHasSpdyPolicy() {
     MockConfigurationPolicyStore store;
     EXPECT_CALL(store, Apply(_, _)).Times(AtLeast(1));
-    cache_->GetManagedPolicyProvider()->Provide(&store);
+    mandatory_cloud_provider_.get()->Provide(&store);
     FundamentalValue expected(true);
-    ASSERT_TRUE(store.Get(kPolicyDisableSpdy) != NULL);
-    EXPECT_TRUE(store.Get(kPolicyDisableSpdy)->Equals(&expected));
+    const PolicyMap* policy_map = cache_->policy(
+        CloudPolicyCacheBase::POLICY_LEVEL_MANDATORY);
+    ASSERT_TRUE(policy_map->Get(kPolicyDisableSpdy));
+    EXPECT_TRUE(policy_map->Get(kPolicyDisableSpdy)->Equals(&expected));
   }
 
   void SetupIdentityStrategy(
       const std::string& device_token,
       const std::string& device_id,
       const std::string& machine_id,
       const std::string& machine_model,
       const std::string& policy_type,
       const em::DeviceRegisterRequest_Type& policy_register_type,
       const std::string& user_name,
@@ skipping 15 matching lines @@
           MockCloudPolicyIdentityStrategyGetCredentials(user_name, auth_token));
     }
   }
 
   void StopMessageLoop() {
     loop_.QuitNow();
   }
 
  protected:
   scoped_ptr<CloudPolicyCacheBase> cache_;
+  scoped_ptr<CloudPolicyProvider> recommended_cloud_provider_;
+  scoped_ptr<CloudPolicyProvider> mandatory_cloud_provider_;
   scoped_ptr<CloudPolicyController> controller_;
   scoped_ptr<MockDeviceTokenFetcher> token_fetcher_;
   MockCloudPolicyIdentityStrategy identity_strategy_;
   MockDeviceManagementBackend backend_;
   MockDeviceManagementService service_;
   PolicyNotifier notifier_;
   ScopedTempDir temp_user_data_dir_;
   MessageLoop loop_;
 
  private:
@@ skipping 121 matching lines @@
                         "who@what.com", "auth");
   EXPECT_CALL(backend_, ProcessPolicyRequest(_, _, _, _)).WillOnce(
       MockDeviceManagementBackendFailPolicy(
           DeviceManagementBackend::kErrorServiceManagementNotSupported));
   EXPECT_CALL(*token_fetcher_.get(), SetUnmanagedState()).Times(1);
   CreateNewController();
   loop_.RunAllPending();
 }
 
 }  // namespace policy