Move user cloud policy to BrowserProcess (was 6979011)

chrome/test/testing_browser_process.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/testing_browser_process.h"
 
 #include "base/string_util.h"
 #include "chrome/browser/google/google_url_tracker.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
+#include "chrome/browser/policy/cloud_policy_cache_base.h"
+#include "chrome/browser/policy/cloud_policy_provider.h"
+#include "chrome/browser/policy/configuration_policy_pref_store.h"
+#include "chrome/browser/policy/dummy_configuration_policy_provider.h"

[Joao da Silva, 2011/06/29 11:36:17]

What are these includes for? They don't seem necessary.

[gfeher, 2011/06/29 12:53:07]

Good question. Let's see if I can remove them.

 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prerender/prerender_tracker.h"
 #include "chrome/browser/printing/background_printing_manager.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TestingBrowserProcess::TestingBrowserProcess()
     : module_ref_count_(0),
@@ skipping 49 matching lines @@
 void TestingBrowserProcess::SetProfileManager(ProfileManager* profile_manager) {
   profile_manager_.reset(profile_manager);
 }
 
 PrefService* TestingBrowserProcess::local_state() {
   return local_state_;
 }
 
 policy::BrowserPolicyConnector*
     TestingBrowserProcess::browser_policy_connector() {
-  if (!browser_policy_connector_.get())
+  if (!browser_policy_connector_.get()) {
     browser_policy_connector_.reset(
         policy::BrowserPolicyConnector::CreateForTests());
+  }
   return browser_policy_connector_.get();
 }
 
 IconManager* TestingBrowserProcess::icon_manager() {
   return NULL;
 }
 
 ThumbnailGenerator* TestingBrowserProcess::GetThumbnailGenerator() {
   return NULL;
 }
@@ skipping 167 matching lines @@
 
 ScopedTestingBrowserProcess::~ScopedTestingBrowserProcess() {
   DCHECK_EQ(browser_process_.get(), g_browser_process);
 
   // TODO(phajdan.jr): Temporary, for http://crbug.com/61062.
   // After the transition is over, we should just
   // reset |g_browser_process| to NULL.
   browser_process_.reset();
   g_browser_process = new TestingBrowserProcess();
 }