Move user cloud policy to BrowserProcess (was 6979011)

chrome/browser/policy/device_policy_cache.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/device_policy_cache.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/task.h"
@@ skipping 163 matching lines @@
                            policy,
                            callback_factory_.NewCallback(
                                &DevicePolicyCache::PolicyStoreOpCompleted));
 }
 
 void DevicePolicyCache::SetUnmanaged() {
   LOG(WARNING) << "Tried to set DevicePolicyCache to 'unmanaged'!";
   // This is not supported for DevicePolicyCache.
 }
 
+bool DevicePolicyCache::IsReady() {

[Mattias Nissler (ping if slow), 2011/06/24 17:27:17]

Hm, now we have IsReady() and initialization_complete(), of which we effectively
use only one, correct? If so, I'd prefer to change the semantics of
initialization_complete() as required.

[gfeher, 2011/06/27 16:50:24]

They actually do mean two different things:
initialization_complete(): we've got a usable policy response either from the
cache/disk storage or from the network
IsReady(): initialization_complete() OR the local disk storage was checked (but
it may have been empty or otherwise corrupted)

initialization_complete() is used for several things:
- in user_policy_cache.cc: avoiding overriding the fresh policy from network
with an old policy from the cache
- in cloud_policy_cache_base.h: determining if the cache has policy or not

I'll make the method protected and improve comments.

+  return initialization_complete() || !starting_up_;
+}
+
 void DevicePolicyCache::OnRetrievePolicyCompleted(
     chromeos::SignedSettings::ReturnCode code,
     const em::PolicyFetchResponse& policy) {
   DCHECK(CalledOnValidThread());
   if (starting_up_) {
     starting_up_ = false;
     if (code == chromeos::SignedSettings::NOT_FOUND ||
         code == chromeos::SignedSettings::KEY_UNAVAILABLE ||
         !policy.has_policy_data()) {
       InformNotifier(CloudPolicySubsystem::UNENROLLED,
@@ skipping 101 matching lines @@
                        Value::CreateStringValue(container.proxy_pac_url()));
     }
     if (container.has_proxy_bypass_list()) {
       recommended->Set(kPolicyProxyBypassList,
                        Value::CreateStringValue(container.proxy_bypass_list()));
     }
   }
 }
 
 }  // namespace policy