Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 7147014: Fix building in release mode with disassembler=on (Closed)

Created:
9 years, 6 months ago by Jakob Kummerow
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix building in release mode with disassembler=on BUG=v8:1473 Committed: http://code.google.com/p/v8/source/detail?r=8311

Patch Set 1 #

Patch Set 2 : modify #ifdefs instead of SConstruct #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/deoptimizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
DeoptimizationInputData::DeoptimizationInputDataPrint(FILE* out) and DeoptimizationOutputData::DeoptimizationOutputDataPrint(FILE* out) are only available if OBJECT_PRINT is #defined, which broke the ...
9 years, 6 months ago (2011-06-14 11:12:32 UTC) #1
Søren Thygesen Gjesse
I think it would be better to remove the #ifdef OBJECT_PRINT in objects.cc instead. The ...
9 years, 6 months ago (2011-06-14 11:29:17 UTC) #2
Jakob Kummerow
Here you go, please take another look.
9 years, 6 months ago (2011-06-15 10:54:32 UTC) #3
Søren Thygesen Gjesse
LGTM Btw. Please update the description with BUG=v8:1473 and close the bug when committed. http://codereview.chromium.org/7147014/diff/2001/src/objects.cc ...
9 years, 6 months ago (2011-06-16 05:50:36 UTC) #4
Jakob Kummerow
9 years, 6 months ago (2011-06-16 08:02:43 UTC) #5
Nit fixed, description updated, patch landed, bug closed :-)

http://codereview.chromium.org/7147014/diff/2001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7147014/diff/2001/src/objects.cc#newcode6805
src/objects.cc:6805: #ifdef ENABLE_DISASSEMBLER
On 2011/06/16 05:50:36, Søren Gjesse wrote:
> This #ifdef should probably be moved down to line 6957 to avoid nested
#ifdefs.

Good point. Done.

Powered by Google App Engine
This is Rietveld 408576698