Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: chrome/test/data/webui/test_api.js

Issue 7146024: Use ExecuteJavascriptInWebFrameNotifyResult to return results even in error condition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't check against |this| in the destructor, which doesn't compile on Win. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/sample_downloads.js ('k') | content/renderer/render_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/test_api.js
diff --git a/chrome/test/data/webui/test_api.js b/chrome/test/data/webui/test_api.js
index 27d94f85d4d4f62ccc138496f5422ab62884146c..1058a2698cd36da60b7ecc5f293fb1843605591d 100644
--- a/chrome/test/data/webui/test_api.js
+++ b/chrome/test/data/webui/test_api.js
@@ -5,16 +5,6 @@
// Library providing basic test framework functionality.
(function() {
- // Indicates a pass to the C++ backend.
- function pass() {
- chrome.send('Pass', []);
- }
-
- // Indicates a fail to the C++ backend.
- function fail(message) {
- chrome.send('Fail', [String(message)]);
- }
-
// Asserts.
// Use the following assertions to verify a condition within a test.
// If assertion fails, the C++ backend will be immediately notified.
@@ -66,14 +56,10 @@
} catch (e) {
console.log(
'Failed: ' + currentTest.name + '\nwith exception: ' + e.message);
-
- fail(e.message);
- return;
+ return [false, e.message] ;
}
-
- // All tests passed.
- pass('');
+ return [true];
}
// Exports.
« no previous file with comments | « chrome/test/data/webui/sample_downloads.js ('k') | content/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698