Use ExecuteJavascriptInWebFrameNotifyResult to return results even in error condition

chrome/browser/ui/webui/web_ui_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/ui/webui/web_ui_browsertest.h"
 
 #include <string>
 #include <vector>
 
 #include "base/path_service.h"
 #include "base/utf_string_conversions.h"
@@ skipping 183 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIBrowserTest, TestSamplePass) {
   AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
 
   // Navigate to UI.
   // TODO(dtseng): make accessor for subclasses to return?
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
 
   ASSERT_TRUE(RunJavascriptTest("testAssertFalse"));
+  ASSERT_FALSE(RunJavascriptTest("FAILS_testAssertFalse"));
   ASSERT_TRUE(RunJavascriptTest("testInitialFocus"));
   ASSERT_FALSE(RunJavascriptTest("testConsoleError"));
 }
+
+// This fails on purpose to test hanging case in crbug.com/85990

[Paweł Hajdan Jr., 2011/06/15 08:18:21]

If this starts passing you won't get any notification. FAILS does not mean
XFAIL. Also, how long does this test take to run?

[Sheridan Rawlins, 2011/06/15 15:41:14]

It was previously the 25s timeout, but with these changes it is now immediate!

Does gtest have a notion of XFAIL?  I don't think so - I'll update the test to
pass by doing checks instead of gtest ASSERT* here.

On 2011/06/15 08:18:21, Paweł Hajdan Jr. wrote:

[Paweł Hajdan Jr., 2011/06/15 15:49:30]

Cool!
Right, I don't think it has XFAIL. FAILS has been added for Chromium in our test
suite, but it only works one way: when a test marked as FAILS fails, the failure
does not influence the exit code; however, if such a test passes, the exit code
is also not changed.

+IN_PROC_BROWSER_TEST_F(WebUIBrowserTest, FAILS_TestFailsFast) {
+  AddLibrary(FilePath(FILE_PATH_LITERAL("sample_downloads.js")));
+  ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIDownloadsURL));
+  ASSERT_FALSE(RunJavascriptTest("FAILS_BogusFunctionName"));
+}