Give correct error message when Object.isExtensible is called on a non object (fixes issue 1452)

Geve correct error message when Object.isExtensible is called on a non object (fixes issue 1452)
Committed: http://code.google.com/p/v8/source/detail?r=8275

[Lasse Reichstein, 2011-06-14 10:30:46]

LGTM

http://codereview.chromium.org/7146010/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7146010/diff/1/src/v8natives.js#newcode632
src/v8natives.js:632: throw MakeTypeError("define_disallowed",
["defineProperty"]);
While you are at it ....,
The message for define_disallowed suggests that the parameter should be the name
of the object that's not extensible. It should probably be the name of the
property, but the message will need rewording for that.

http://codereview.chromium.org/7146010/diff/1/src/v8natives.js#newcode662
src/v8natives.js:662: throw MakeTypeError("redefine_disallowed",
["defineProperty"]);
And this error message suggests that the parameter should be the property name,
not the defineProperty function's name.

[Rico, 2011-06-14 11:00:20]

Changed both error messages to take the parameter name

[Lasse Reichstein, 2011-06-14 11:17:15]

LGTM

http://codereview.chromium.org/7146010/diff/4/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/7146010/diff/4/src/messages.js#newcode193
src/messages.js:193: define_disallowed:            ["Cannot define property ",
"%0", ", object is not extensible."],
':' after 'property' (or quotes around %0) to separate it from the sentence.

http://codereview.chromium.org/7146010/diff/4/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7146010/diff/4/src/v8natives.js#newcode632
src/v8natives.js:632: throw MakeTypeError("define_disallowed", [ToString(p)]);
Here 'p' is always a primitive, right?

[Rico, 2011-06-14 11:25:15]

http://codereview.chromium.org/7146010/diff/4/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/7146010/diff/4/src/messages.js#newcode193
src/messages.js:193: define_disallowed:            ["Cannot define property ",
"%0", ", object is not extensible."],
On 2011/06/14 11:17:15, Lasse Reichstein wrote:
> ':' after 'property' (or quotes around %0) to separate it from the sentence.

Done.

http://codereview.chromium.org/7146010/diff/4/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7146010/diff/4/src/v8natives.js#newcode632
src/v8natives.js:632: throw MakeTypeError("define_disallowed", [ToString(p)]);
On 2011/06/14 11:17:15, Lasse Reichstein wrote:
> Here 'p' is always a primitive, right?

Done and below (yes, we already always called ToString on this before calling
this function)