Improve and unify Mac OS X run-time version checks

chrome/browser/bug_report_util.cc

Index: chrome/browser/bug_report_util.cc
===================================================================
--- chrome/browser/bug_report_util.cc	(revision 88826)
+++ chrome/browser/bug_report_util.cc	(working copy)
@@ -167,11 +167,7 @@
   if (service_pack > 0)
     os_version->append(StringPrintf("Service Pack %d", service_pack));
 #elif defined(OS_MACOSX)
-  int32 major;
-  int32 minor;
-  int32 bugFix;
-  base::SysInfo::OperatingSystemVersionNumbers(&major, &minor, &bugFix);
-  *os_version = StringPrintf("%d.%d.%d", major, minor, bugFix);
+  *os_version = base::SysInfo::OperatingSystemVersion();

[Avi (use Gerrit), 2011/06/13 22:45:22]

DCHECK? NOTIMPLEMENTED?

[Mark Mentovai, 2011/06/14 00:18:26]

Avi wrote:
I don’t get it. What would you DCHECK or NOTIMPLEMENTED here?

The Mac’s base::SysInfo::OperatingSystemVersion (base/sys_info_mac.cc) does
|base::StringPrintf("%d.%d.%d", major, minor, bugfix)| in exactly the same way
as the code that had been here.

[Avi (use Gerrit), 2011/06/14 01:40:23]

Misread. My bad.

 #else
   *os_version = "unknown";
 #endif