Add profiles to wrench menu

ui/base/models/simple_menu_model.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/models/simple_menu_model.h"
 
 #include "base/message_loop.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 162 matching lines @@
 }
 
 void SimpleMenuModel::SetIcon(int index, const SkBitmap& icon) {
   items_[index].icon = icon;
 }
 
 void SimpleMenuModel::Clear() {
   items_.clear();
 }
 
+void SimpleMenuModel::RemoveItemAt(int index) {

[sail, 2011/06/10 06:57:31]

This change isn't ready yet but I'm stuck on this part.
I need to be able to change the menu as the user adds and removes profiles.
I tried changing the menu model but this ends up crashing in the UI code. It
looks like the UI code doesn't realize that the model has changed and it starts
to dereference stale pointers.

Is there a good way to do this? Thanks!

[Nico, 2011/06/10 14:34:23]

Several SimpleMenuModel clients create a new ui menu from the model every time
the menu is displayed. That sounds like a simple way to make this work. Which
platform are you seeing this problem on?

[sail, 2011/06/10 14:52:59]

I'm seeing this on mac.
So do I change wrench menu controller to build a new menu each time? This will
mean that I have to move the edit and zoom buttons into a separate nib. Is that
ok?

[sky, 2011/06/10 16:24:14]

The windows side does this. Of course you would have to take care not to modify
the model while the menu is showing, otherwise bad things would happen. 

[Robert Sesek, 2011/06/10 16:46:26]

In general, MenuModel is immutable after creation. There are no delegate
notifications for when the Model changes and all the clients (at least on Mac)
do not expect for the model to mutate.

I may be mis-remembering, so take this with a grain of salt, but I think moving
views between menu items did not work in the past. So, you would need to move
the objects into a new xib and re-load it each time.

Unfortunately, the current architecture of the WMC doesn't really expect this.
If you need me to help at all with this, let me know.

The other option, which I think would be all-around preferable, would be to make
a MutableMenuModel which would broadcast change notifications to its delegate.
This has been something that I've been meaning to do for a while but haven't had
the time to pick up. Then the model wouldn't have to be rebuilt each time and
items could be added/inserted/mutated at will.

+  items_.erase(items_.begin() + FlipIndex(index));
+}
+
 int SimpleMenuModel::GetIndexOfCommandId(int command_id) {
   std::vector<Item>::iterator itr;
   for (itr = items_.begin(); itr != items_.end(); itr++) {
     if ((*itr).command_id == command_id) {
       return FlipIndex(static_cast<int>(std::distance(items_.begin(), itr)));
     }
   }
   return -1;
 }
 
@@ skipping 146 matching lines @@
 #ifndef NDEBUG
   if (item.type == TYPE_SEPARATOR) {
     DCHECK_EQ(item.command_id, kSeparatorId);
   } else {
     DCHECK_GE(item.command_id, 0);
   }
 #endif  // NDEBUG
 }
 
 }  // namespace ui