Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3323)

Unified Diff: chrome/chrome_exe.gypi

Issue 7135006: Remove rendundant use of product_name in gyp files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/third_party/nss/ssl.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 547d7bd229b861862ec08ac611d0a4100f2d4977..d33689408d518540560f5a72e5ed11edec9eb2ec 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -420,18 +420,14 @@
}],
['OS != "mac"', {
'conditions': [
- ['branding=="Chrome"', {
- 'product_name': 'chrome'
- }, { # else: Branding!="Chrome"
- # TODO: change to:
- # 'product_name': 'chromium'
- # whenever we convert the rest of the infrastructure
- # (buildbots etc.) to use "gyp -Dbranding=Chrome".
- # NOTE: chrome/app/theme/chromium/BRANDING and
- # chrome/app/theme/google_chrome/BRANDING have the short names,
- # etc.; should we try to extract from there instead?
- 'product_name': 'chrome'
- }],
+ # TODO: add a:
+ # 'product_name': 'chromium'
+ # whenever we convert the rest of the infrastructure
+ # (buildbots etc.) to understand the branding gyp define.
+ # NOTE: chrome/app/theme/chromium/BRANDING and
+ # chrome/app/theme/google_chrome/BRANDING have the short name
+ # "chrome" etc.; should we try to extract from there instead?
+
# On Mac, this is done in chrome_dll.gypi.
['internal_pdf', {
'dependencies': [
« no previous file with comments | « no previous file | net/third_party/nss/ssl.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698