Issue 7135006: Remove rendundant use of product_name in gyp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7135006: Remove rendundant use of product_name in gyp files. (Closed)

Created:
9 years, 6 months ago by Evan Martin

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove rendundant use of product_name in gyp files. We default to using the target name as the product name; there's no need to state it twice. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88556

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -17 lines)			Patch
M	chrome/chrome_exe.gypi	View	1	1 chunk	+8 lines, -12 lines	0 comments	Download
M	net/third_party/nss/ssl.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/ppapi_tests.gypi	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	third_party/iccjpeg/iccjpeg.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/qcms/qcms.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

willchan no longer on Chromium

9 years, 6 months ago (2011-06-09 18:19:25 UTC) #4

LGTM

On Thu, Jun 9, 2011 at 9:15 PM,  <evan@chromium.org> wrote:
> need owners approval, lol
>
> http://codereview.chromium.org/7135006/
>